ComposeAppBar fixed title text style plus minor code cleanup #711
Conversation
renamed navgraph code cleanup - removed unused AddFolderActivity
There was a problem hiding this comment.
Pull Request Overview
This PR addresses Compose App Bar title styling issues and includes code cleanup by removing the unused AddFolderActivity. The changes consolidate folder creation functionality into the existing SpaceSetupActivity flow.
- Fixed ComposeAppBar title text style by moving it to a shared location and improving styling
- Increased font size for passcode setup screen description text for better readability
- Removed unused AddFolderActivity class and consolidated folder creation through SpaceSetupActivity
Reviewed Changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/libs.versions.toml | Updated dependency versions for ksp and work libraries |
| app/src/main/res/layout/*.xml | Updated layout references and removed unused activity context |
| app/src/main/java/.../PasscodeSetupScreen.kt | Increased warning text font size from 13sp to 15sp |
| app/src/main/java/.../PasscodeSetupActivity.kt | Updated import path for ComposeAppBar |
| app/src/main/java/.../NumericKeypad.kt | Code cleanup with unused import removal and preview improvements |
| app/src/main/java/.../ProofModeScreen.kt | Updated import path for ComposeAppBar |
| app/src/main/java/.../FoldersActivity.kt | Removed commented-out code |
| app/src/main/java/.../SpaceSetupActivity.kt | Updated navigation graph reference and added constants |
| app/src/main/java/.../MainActivity.kt | Updated references from AddFolderActivity to SpaceSetupActivity |
| app/src/main/java/.../InternetArchiveLoginScreen.kt | Removed ComposeAppBar definition and unused imports |
| app/src/main/java/.../InternetArchiveHeader.kt | Package rename and import cleanup |
| app/src/main/java/.../InternetArchiveLocalSource.kt | Removed unused import |
| app/src/main/java/.../CreateNewFolderFragment.kt | Updated references to use SpaceSetupActivity constants |
| app/src/main/java/.../BrowseFoldersFragment.kt | Updated references and removed commented code |
| app/src/main/java/.../AddFolderActivity.kt | Completely removed unused activity class |
| app/src/main/java/.../ComposeAppBar.kt | New shared ComposeAppBar component with improved styling |
| app/src/main/java/.../Preview.kt | Enhanced preview components with Koin dependency injection |
| app/src/main/AndroidManifest.xml | Removed AddFolderActivity and HomeActivity registrations |
| app/src/debug/AndroidManifest.xml | New debug-only manifest for HomeActivity |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @OptIn(ExperimentalMaterial3Api::class) | ||
| @Composable | ||
| fun ComposeAppBar( | ||
| title: String = "", | ||
| onNavigationAction: () -> Unit = {} | ||
| ) { | ||
| TopAppBar( | ||
| modifier = Modifier.fillMaxWidth(), | ||
| title = { | ||
| Text( | ||
| text = title, | ||
| style = MaterialTheme.typography.headlineSmall, | ||
| maxLines = 1, | ||
| overflow = TextOverflow.Ellipsis | ||
| ) | ||
| }, | ||
| navigationIcon = { | ||
| IconButton(onClick = onNavigationAction) { | ||
| Icon( | ||
| painter = painterResource(R.drawable.ic_arrow_back_ios), | ||
| contentDescription = null | ||
| ) | ||
| } | ||
| }, | ||
| colors = TopAppBarDefaults.topAppBarColors( | ||
| containerColor = MaterialTheme.colorScheme.tertiary, | ||
| navigationIconContentColor = Color.White, | ||
| titleContentColor = Color.White, | ||
| actionIconContentColor = Color.White | ||
| ) | ||
| ) | ||
| } |
Check warning
Code scanning / detekt
Library classes should not be public. Warning
|
|
||
| @OptIn(ExperimentalMaterial3Api::class) | ||
| @Composable | ||
| fun ComposeAppBar( |
Check warning
Code scanning / detekt
This @Composable function emits content but doesn't have a modifier parameter. See https://mrmans0n.github.io/compose-rules/rules/#when-should-i-expose-modifier-parameters for more information. Warning
|
|
||
| @OptIn(ExperimentalMaterial3Api::class) | ||
| @Composable | ||
| fun ComposeAppBar( |
Check warning
Code scanning / detekt
Function names should follow the naming convention set in the configuration. Warning
Compose App Bar title style fixed
increased fontsize for passcode setup screen description
renamed navgraph
code cleanup - removed unused AddFolderActivity