Skip to content

Conversation

@Elelan
Copy link

@Elelan Elelan commented Sep 19, 2025

-Removed animated splash and added normal splash image -Onboarding skip btn fixed font weight - semi bold -ProofMode - text increased line space

  • crashlytics library upgrade

-Removed animated splash and added normal splash image
-Onboarding skip btn fixed font weight - semi bold
-ProofMode - text increased line space
- crashlytics library upgrade
Copilot AI review requested due to automatic review settings September 19, 2025 10:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements QA feedback fixes across splash screen, onboarding, and ProofMode features to improve user experience and visual consistency. The changes focus on replacing animated elements with static ones, improving text formatting, and upgrading dependencies.

  • Replaced animated splash screen with static image for better performance
  • Fixed font weight inconsistency in onboarding skip button
  • Improved ProofMode text readability with increased line height and proper spacing

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
gradle/libs.versions.toml Updated lifecycle and Firebase Crashlytics library versions
app/src/main/res/values/styles.xml Changed splash screen from animated to static icon
app/src/main/res/values/strings.xml Capitalized "Learn more here" text and added extra line break
app/src/main/res/layout/activity_settings_container.xml Increased line height, reduced padding, and added font family for ProofMode text
app/src/main/res/layout/activity_onboarding23_instructions.xml Changed skip button font from bold to semi-bold
app/src/main/res/drawable/save_splash.xml Added new static splash screen vector drawable

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


<string name="proof_mode_warning_text"><![CDATA[
To help verify where your media was captured, ProofMode gathers data from nearby cell towers to corroborate your location. To add credibility and context, it then includes a separate metadata file with your media*. Android requires location access to collect this information.<br/><br/>
To help verify where your media was captured, ProofMode gathers data from nearby cell towers to corroborate your location. To add credibility and context, it then includes a separate metadata file with your media*. Android requires location access to collect this information.<br/><br/></br>
Copy link

Copilot AI Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HTML markup contains an incorrect closing tag </br> at the end. This should be <br/> (self-closing) or removed entirely since there's already <br/><br/> providing the line breaks.

Suggested change
To help verify where your media was captured, ProofMode gathers data from nearby cell towers to corroborate your location. To add credibility and context, it then includes a separate metadata file with your media*. Android requires location access to collect this information.<br/><br/></br>
To help verify where your media was captured, ProofMode gathers data from nearby cell towers to corroborate your location. To add credibility and context, it then includes a separate metadata file with your media*. Android requires location access to collect this information.<br/><br/>

Copilot uses AI. Check for mistakes.
Elelan and others added 2 commits September 19, 2025 16:40
The `<br/></br>` was changed to `<br/><br/>` in the `proof_mode_warning_text` string resource to render the line breaks correctly.
@Elelan Elelan merged commit fde2ee9 into next Sep 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants