fix: terminate podcast on program exit #1300
Open
+16
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
letsfindaway
force-pushed
the
fix-terminate-podcast
branch
from
3e7ba80 to
2a3236f
Compare
- when OpenBoard is closed while a podcast is running the application is hanging waiting for a thread to finish - cleanly terminate the podcast recording before closing the application Signed-off-by: letsfindaway <me@letsfindaway.de>
letsfindaway
force-pushed
the
fix-terminate-podcast
branch
from
2a3236f to
c7809d9
Compare
Collaborator
Author
|
I now added a timer to avoid endless waiting. Also note that a similar construct using @kaamui : If you think it would be useful I can also move the target branch to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes letsfindaway#223
Note: The
lastWindowClosedsignal is not emitted from the application when terminating OpenBoard. We therefore now connect toUBMainWindow::closeEvent_Signal. This also affects other locations, but there we always have another way in place to detect termination, so I did not touch them.