Skip to content

Conversation

@sebojolais
Copy link
Contributor

Fixes the issue #1349.

@Vekhir
Copy link
Contributor

Vekhir commented Oct 20, 2025

Please don't change the name in the source file - It's the reference for the translations which would all have to be adapted as well.

There are both OpenBoard_en.ts and OpenBoard_en_UK.ts translation files. I'm not sure whether the "en" version is supposed to be en_US or just a default. In any case, as the difference is US vs UK spelling, you might want to add an explicit OpenBoard_en_US.ts translation file for your spelling.

@sebojolais
Copy link
Contributor Author

Hi Vekhir,
The both files OpenBoard_en.ts and OpenBoard_en_UK.ts are identical.
It does not help us to handle this issue...

@sebojolais
Copy link
Contributor Author

And I agree, this topic should not induce a new entry for every translation files.
So it will be better to fix it in a .ts file.

@sebojolais sebojolais force-pushed the fix_licenses_string_tab branch from 0ccfe19 to 554e7af Compare October 20, 2025 21:57
@sebojolais sebojolais force-pushed the fix_licenses_string_tab branch from 554e7af to 3819b1a Compare October 20, 2025 22:02
@Vekhir
Copy link
Contributor

Vekhir commented Oct 20, 2025

As there are bound to be other differences, it might be most useful to copy the OpenBoard_en.ts to create an OpenBoard_en_US.ts translation.
I'd rather have the default be the British spelling as that is the most commonly taught dialect of English in many parts of Europe, and - I assume - in Switzerland where this software has its origins.

@sebojolais
Copy link
Contributor Author

I changed the implementation.
Currently, the string is changed only in OpenBoard_en.ts and not in OpenBoard_en_UK.ts.
But it is the first difference introduced between the files, so I am not sure that is best way.

@sebojolais
Copy link
Contributor Author

Currently, this PR introduces minimal changes.
I am waiting @kaamui feedback before changing the name of file.
Even If I agree with you @Vekhir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants