Cleanup Flash, AppleWidget and NPAPI related code #1355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove UBMimeType enum value - remove mime type handling in UBFileSystemUtils - remove handling in UBFeaturesWidget - remove handling in UBFeaturesController - remove handling in UBBoardController - remove related settings in UBSettings and OpenBoard.config - remove a related comment in UBWidgetUniboardAPI Signed-off-by: letsfindaway <me@letsfindaway.de>
- remove UBMimeType enum value - remove mime type handling in UBFileSystemUtils - remove reading and writing in UBSvgSubsetAdaptor - remove handling in UBBoardController - remove handling in UBGraphicsScene - remove class UBGraphicsAppleWidgetItem Signed-off-by: letsfindaway <me@letsfindaway.de>
- remove unused signal from UBBoardController - remove related unused slot from UBFeaturesController - remove unused related functions from UBGraphicsW3CWidgetItem - remove obsolete files for npapi-wrapper in resources/etc - remove installation of file from CMakeLists.txt Signed-off-by: letsfindaway <me@letsfindaway.de>
- remove unused includes from files modified by previous commits - reorder and sort includes Signed-off-by: letsfindaway <me@letsfindaway.de>
letsfindaway
force-pushed
the
cleanup-flash-applewidget
branch
from
146295d to
713c202
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenBoard still contains some code related to long abandoned features:
This PR removes the dead code and related files. Eliminating unnecessary code improves the software's maintainability.