Fix integer division in EV3 motor code#6
Open
MaartenS11 wants to merge 2 commits intoOpenBotBrain:mainfrom
Open
Fix integer division in EV3 motor code#6MaartenS11 wants to merge 2 commits intoOpenBotBrain:mainfrom
MaartenS11 wants to merge 2 commits intoOpenBotBrain:mainfrom
Conversation
The integer division caused any speed lower than 1000 to become 0resulting in a motor that didn't do anything.
sggtav
approved these changes
Dec 9, 2023
Contributor
sggtav
left a comment
sggtav
left a comment
There was a problem hiding this comment.
It is a good practice to add the “f” at the end of the float values, like 123.4f. But it is fine as is.
sggtav
approved these changes
Dec 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an integer division in the EV3 large motor code that took the speed and divided by 1000. The speed of the motor is an integer, 1000 is also an integer so it did an integer division. If you set the speed to
DEFAULT_MOTOR_SPEEDfor example this results in the value0instead of the expected0.5.This integer division made it impossible to make the motor move at speeds below the maximum speed.