Added meter and group for BG17 test#1577
Added meter and group for BG17 test#1577huss merged 8 commits intoOpenEnergyDashboard:developmentfrom
Conversation
Removed comment placeholder for BG17 test case.
Co-authored-by: Kaissy Amaro <kamaro@csumb.edu> Co-authored-by: Ashlin John <ajohn6@hawk.iit.edu>
Ryan-z-Feng-ccsf
left a comment
There was a problem hiding this comment.
This is our final test BG17. It works perfectly
|
@kaissy-a, @Ryan-z-Feng-ccsf & any others. Thank you for this contribution. First, the description template was mostly not filled in. The checklist is of particular importance. It also needs to use "Partly address #962" and not "Fixes" so the issue will not close. Second, I looked at the OED CLA records but do not see either GitHub ID as listed for having done the form. I also noticed that other GitHub IDs are listed with commits. Could you provide a list of the GitHub IDs of anyone who worked on this. Also, can everyone who worked on this do the CLA form (link above) or let me know if you think our records are off. Thanks and let me know if you need anything. |
huss
left a comment
There was a problem hiding this comment.
Thanks to @jujusjuicebox, @Ryan-z-Feng-ccsf & @kaissy-a for this contribution. Testing and review found that everything is fine. Congratulations on your first accepted contribution to OED.
Description
Added test case BG17 for 1-bar graphs with 15-20 reading intervals, flow units with +- inf start/end times, and kW units. This test validates the bar graph aggregation behavior across different reading intervals and time.
Authors:
@jujusjuicebox
@Ryan-z-Feng-ccsf
@kaissy-a
Partly Addresses #[962]
Type of change
(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])
Checklist
(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)
Limitations
Implementation follows established test patterns in the code base.