Skip to content

Comments

Added meter and group for BG17 test#1577

Merged
huss merged 8 commits intoOpenEnergyDashboard:developmentfrom
Ryan-z-Feng-ccsf:teamE-kaissy
Feb 10, 2026
Merged

Added meter and group for BG17 test#1577
huss merged 8 commits intoOpenEnergyDashboard:developmentfrom
Ryan-z-Feng-ccsf:teamE-kaissy

Conversation

@kaissy-a
Copy link
Contributor

@kaissy-a kaissy-a commented Feb 8, 2026

Description

Added test case BG17 for 1-bar graphs with 15-20 reading intervals, flow units with +- inf start/end times, and kW units. This test validates the bar graph aggregation behavior across different reading intervals and time.

Authors:
@jujusjuicebox
@Ryan-z-Feng-ccsf
@kaissy-a

Partly Addresses #[962]

Type of change

(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])

  • [] Note merging this changes the database configuration.
  • [] This change requires a documentation update

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

  • I have followed the OED pull request ideas
  • [] I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

Implementation follows established test patterns in the code base.

@kaissy-a kaissy-a marked this pull request as draft February 8, 2026 02:44
Copy link
Contributor

@Ryan-z-Feng-ccsf Ryan-z-Feng-ccsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is our final test BG17. It works perfectly

@huss
Copy link
Member

huss commented Feb 9, 2026

@kaissy-a, @Ryan-z-Feng-ccsf & any others. Thank you for this contribution. First, the description template was mostly not filled in. The checklist is of particular importance. It also needs to use "Partly address #962" and not "Fixes" so the issue will not close. Second, I looked at the OED CLA records but do not see either GitHub ID as listed for having done the form. I also noticed that other GitHub IDs are listed with commits. Could you provide a list of the GitHub IDs of anyone who worked on this. Also, can everyone who worked on this do the CLA form (link above) or let me know if you think our records are off. Thanks and let me know if you need anything.

@kaissy-a kaissy-a marked this pull request as ready for review February 10, 2026 02:30
Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @jujusjuicebox, @Ryan-z-Feng-ccsf & @kaissy-a for this contribution. Testing and review found that everything is fine. Congratulations on your first accepted contribution to OED.

@huss huss merged commit 911ff4b into OpenEnergyDashboard:development Feb 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants