Open
Conversation
Co-authored-by: Alexander Sher <sher.alex05@gmail.com> Co-authored-by: Gokul Krishna Radhakrishnan Nair <gradhakrishnannair@sfsu.edu>
Co-authored-by: Alexander Sher <sher.alex05@gmail.com> Co-authored-by: Gokul Krishna Radhakrishnan Nair <gradhakrishnannair@sfsu.edu>
Co-authored-by: Alexander Sher <sher.alex05@gmail.com> Co-authored-by: Gokul Krishna Radhakrishnan Nair <gradhakrishnannair@sfsu.edu>
Member
|
@RyRy241 Thank you for this contribution to OED. I see the box about completing the CLA is checked. I wanted to say:
Could you please provide their GitHub IDs and anyone else who worked on this. I tried to find them in the CLA records but could not. Please let me know if anything is not clear or you have questions. |
Author
|
@huss, we have all now completed the CLA form. Our team's GitHub usernames are listed below: Ryan Selvarajan RyRy241 Please let me know if there is anything else you need from us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the test case CG10, which verifies a one-day shift ending at 2022-10-31 17:00:00 using 15-minute reading intervals, and confirms that quantity unit conversion from kWh to BTU works correctly in the compare readings API. To support this test, we added:
Unit u16: BTU (quantity unit)
Conversion c3: MJ → BTU (bidirectional) with slope 947.8 and intercept 0
The test sets up units/conversions, fetches the dynamically assigned BTU unit ID from the DB, with shift=P1D, and asserts the returned values match the expected BTU results
Partly Addresses: testing Readings #962
(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])
Checklist
(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)
Limitations
We were able to implement the code, but since time was limited, we weren't able to test the application to see if our test case worked as intended.