Skip to content

Comments

Added test CG10#1578

Open
RyRy241 wants to merge 3 commits intoOpenEnergyDashboard:developmentfrom
AlexS2005:development
Open

Added test CG10#1578
RyRy241 wants to merge 3 commits intoOpenEnergyDashboard:developmentfrom
AlexS2005:development

Conversation

@RyRy241
Copy link

@RyRy241 RyRy241 commented Feb 15, 2026

This pull request implements the test case CG10, which verifies a one-day shift ending at 2022-10-31 17:00:00 using 15-minute reading intervals, and confirms that quantity unit conversion from kWh to BTU works correctly in the compare readings API. To support this test, we added:

Unit u16: BTU (quantity unit)

Conversion c3: MJ → BTU (bidirectional) with slope 947.8 and intercept 0

The test sets up units/conversions, fetches the dynamically assigned BTU unit ID from the DB, with shift=P1D, and asserts the returned values match the expected BTU results

Partly Addresses: testing Readings #962

(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

We were able to implement the code, but since time was limited, we weren't able to test the application to see if our test case worked as intended.

RyRy241 and others added 3 commits February 15, 2026 12:15
Co-authored-by: Alexander Sher <sher.alex05@gmail.com>
Co-authored-by: Gokul Krishna Radhakrishnan Nair <gradhakrishnannair@sfsu.edu>
Co-authored-by: Alexander Sher <sher.alex05@gmail.com>
Co-authored-by: Gokul Krishna Radhakrishnan Nair <gradhakrishnannair@sfsu.edu>
Co-authored-by: Alexander Sher <sher.alex05@gmail.com>
Co-authored-by: Gokul Krishna Radhakrishnan Nair <gradhakrishnannair@sfsu.edu>
@huss
Copy link
Member

huss commented Feb 17, 2026

@RyRy241 Thank you for this contribution to OED. I see the box about completing the CLA is checked. I wanted to say:

  • I didn't find a record of you having filled out the CLA form. Could you either do it using the link in the description or let me know if you think our records are in error.
  • A commit has as co-authors:

Could you please provide their GitHub IDs and anyone else who worked on this. I tried to find them in the CLA records but could not.

Please let me know if anything is not clear or you have questions.

@RyRy241
Copy link
Author

RyRy241 commented Feb 18, 2026

@huss, we have all now completed the CLA form. Our team's GitHub usernames are listed below:

Ryan Selvarajan RyRy241
Alexander Sher: AlexS2005
Gokul Krishna Radhakrishnan Nair: gokulkrishnakotta

Please let me know if there is anything else you need from us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants