Issue 1217 - CSV Upload Validation Checks#1579
Open
kyle-parker-1500 wants to merge 45 commits intoOpenEnergyDashboard:developmentfrom
Open
Issue 1217 - CSV Upload Validation Checks#1579kyle-parker-1500 wants to merge 45 commits intoOpenEnergyDashboard:developmentfrom
kyle-parker-1500 wants to merge 45 commits intoOpenEnergyDashboard:developmentfrom
Conversation
…ion for checking each value towards the bottom of the uploadMeters.js file as well as calling them when the submission is sent to the server
… made sure the correct data was being sent back to the client side
…ifferent caps/lowercase
…csv-validation Boolean value validations
…csv-validation Min max validation
Merge branch 'Issue1217-csv-validation' of https://github.com/SageMar/OED into Issue1217-csv-validation
…ecked, now it converts strings to ints and functions
…checked for validity before calling it to check min<max
… decimals are passing through
finished isDuplicate()
corrected isValidDate() logic
…TimeFormat, isDuplicate before PR
…imeFormat, isDuplicate
Co-authored-by: Destiny Veloz <destinyveloz@msn.com> Co-authored-by: Oscar Aviles-Saldana <oaviles-saldana@csumb.edu>
Co-authored-by: Destiny Veloz destinyveloz@msn.com Co-authored-by: Oscar Aviles-Saldana oaviles-saldana@csumb.edu
Co-authored-by: Destiny Veloz <destinyveloz@msn.com> Co-authored-by: Oscar Aviles-Saldana <oaviles-saldana@csumb.edu>
…vilSal/OED into final_checks_uploadMeters
Member
|
@kyle-parker-1500 Thank you for this PR. I see the CLA box is checked in the description. Given this, could you help with these:
Please let me know if anything is not clear or you have thoughts. |
Author
|
Hi @huss , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Partly Addresses #1217
Type of change
Added validation checks for the following 6 fields within the
uploadMeters.jsfile according to the note left on PR1403:Checklist
Limitations
The branch which these changes were pushed on is around 300 commits behind the development branch. Also not all meters have checks being done on them, only those listed in PR1403 and those listed here. Destiny destinyveloz@msn.com, Oscar oaviles-saldana@csumb.edu, and I kylerparker1500@gmail.com are open to continue working on this issue.
Thank you to @SageMar and @cmatthews444 for writing the previous checks, much of our code was derived from what you wrote.