Skip to content

Comments

Issue 1217 - CSV Upload Validation Checks#1579

Open
kyle-parker-1500 wants to merge 45 commits intoOpenEnergyDashboard:developmentfrom
OscarAvilSal:final_checks_uploadMeters
Open

Issue 1217 - CSV Upload Validation Checks#1579
kyle-parker-1500 wants to merge 45 commits intoOpenEnergyDashboard:developmentfrom
OscarAvilSal:final_checks_uploadMeters

Conversation

@kyle-parker-1500
Copy link

@kyle-parker-1500 kyle-parker-1500 commented Feb 15, 2026

Description

Partly Addresses #1217

Type of change

Added validation checks for the following 6 fields within the uploadMeters.js file according to the note left on PR1403:

  1. Max Error: Max Error must be within the range of 0 to 75.
  2. Area Unit & Value: If area unit is none then area cannot be specified.
  3. Min & Max Dates: The max date cannot be before the min date & validate if they are dates.
  4. Duplicates: Duplicates within the range of 1 to 9.
  5. Reading Gap: Should be greater than or equal to 0.
  6. Reading Variation: Should be greater than or equal to 0.
  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

The branch which these changes were pushed on is around 300 commits behind the development branch. Also not all meters have checks being done on them, only those listed in PR1403 and those listed here. Destiny destinyveloz@msn.com, Oscar oaviles-saldana@csumb.edu, and I kylerparker1500@gmail.com are open to continue working on this issue.

Thank you to @SageMar and @cmatthews444 for writing the previous checks, much of our code was derived from what you wrote.

SageMar and others added 30 commits November 27, 2024 15:51
…ion for checking each value towards the bottom of the uploadMeters.js file as well as calling them when the submission is sent to the server
… made sure the correct data was being sent back to the client side
…csv-validation

Boolean value validations
Merge branch 'Issue1217-csv-validation' of https://github.com/SageMar/OED into Issue1217-csv-validation
…ecked, now it converts strings to ints and functions
…checked for validity before calling it to check min<max
@huss
Copy link
Member

huss commented Feb 17, 2026

@kyle-parker-1500 Thank you for this PR. I see the CLA box is checked in the description. Given this, could you help with these:

  • I could not find an entry for you in our CLA records. Could you either do it or let me know if you think our records are wrong.
  • Our CLA records are by GitHub ID. I found @DestinyVeloz & @OscarAvilSal who I think might be the two other people listed. Could you or the other people verify that I have the correct GitHub IDs.

Please let me know if anything is not clear or you have thoughts.

@kyle-parker-1500
Copy link
Author

Hi @huss ,
That may have been my fault. I use a very similar username that I may have typed in by accident. I resubmitted the CLA with my current GitHub ID so I'm hoping that works out. The other IDs are correct. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants