Fix Information Disclosure#1580
Draft
Zachary-Squires wants to merge 17 commits intoOpenEnergyDashboard:developmentfrom
Draft
Fix Information Disclosure#1580Zachary-Squires wants to merge 17 commits intoOpenEnergyDashboard:developmentfrom
Zachary-Squires wants to merge 17 commits intoOpenEnergyDashboard:developmentfrom
Conversation
Accidentally pushed with OED_PRODUCTION set to yes
Added: 1. Banners for the make sure to change this value notifications, also added a notification for the token secret. 2. Fixed spelling error. 3. Added spaces to comments. 4. A variable that checks what the installation type is at the start and is used for all checks.
Added comments in docker-compose.yml to alert users as to the fact passwords are only drawn from this file once. Added something to the .env file to show the code that the password has already been generated. Changed a redundant if statement to an else.
Changes to address feedback on 1/19, added/edited comments, changed changePass.js to changePostgresPass.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes www and app.js to improve production security by preventing internal error details from being exposed to users. Error responses now return generic messages instead of stack traces or system information, while full details are still logged internally for debugging. The update also removes identifying headers and adds safeguards to properly handle unexpected failures, reducing the risk of sensitive information being disclosed.
Developed and implemented by:
Zachary Squires - https://github.com/Zachary-Squires
Fixes Pentest Issue #14
Type of change
(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])
Checklist
Limitations
These changes mitigate information disclosure through application error handling but do not eliminate all potential exposure risks. Proper environment configuration and secure log management are still required to maintain production security.