-
Notifications
You must be signed in to change notification settings - Fork 508
[OLAF] Implementation of a source panel method #2945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jjonkman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review of the new input file documentation only.
|
@ebranlard Has the sphere unit test been added already, or is that still to be completed? |
The r-test for the potential flow about a sphere is now added, see here |
26fc588 to
5dabe9b
Compare
|
One of the regression tests is failing due to an incomplete preceding test (restart case). This is unrelated to the changes here. |
jjonkman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments and updating the acknowledgements!
|
Thank you for the fast turnaround! |
This pull request is a draft
Feature or improvement description
Impacted areas of the software
AeroDyn / OLAF
Supporting information
FVW_BiotSavart.f90FVW_Subswith the suffix:srcPnl_T_SrcPanl*similar toT_SgmtandT_Part.Test results, if applicable
A unittest is included as part of
FVW_Teststo check that the Cp of a sphere match the analytical value.