Skip to content

Conversation

@ebranlard
Copy link
Contributor

@ebranlard ebranlard commented Aug 5, 2025

This pull request is a draft

Feature or improvement description

  • Adds source panels to OLAF to model walls, and bodies of arbitrary shapes, provided they are not moving or being deformed elastically.
  • Allows the AeroDyn driver to be run with 0 blades (i.e. just source panels)
  • Improved VTK reading and writting

Impacted areas of the software
AeroDyn / OLAF

Supporting information

  • Basic induced velocity calculation placed in FVW_BiotSavart.f90
  • Main source panel routines placed in FVW_Subs with the suffix: srcPnl_
  • All data stored into type T_SrcPanl* similar to T_Sgmt and T_Part.

Test results, if applicable
A unittest is included as part of FVW_Tests to check that the Cp of a sphere match the analytical value.

  • Input file documentation, live version here
  • r-test of the potential flow about a sphere, see here
  • Acknowledge sponsor Accelerate Wind in source code, and potential banner when Src Panel used.

@andrew-platt andrew-platt added this to the v5.0.0 milestone Aug 6, 2025
@andrew-platt andrew-platt self-assigned this Aug 6, 2025
@andrew-platt andrew-platt requested a review from jjonkman August 6, 2025 16:22
@andrew-platt andrew-platt marked this pull request as draft August 6, 2025 17:24
Copy link
Collaborator

@jjonkman jjonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of the new input file documentation only.

@hkross
Copy link
Contributor

hkross commented Oct 31, 2025

@ebranlard Has the sphere unit test been added already, or is that still to be completed?

@ebranlard ebranlard changed the base branch from dev-tc to dev December 18, 2025 22:21
@ebranlard ebranlard changed the base branch from dev to dev-tc December 18, 2025 22:21
@ebranlard ebranlard marked this pull request as ready for review December 19, 2025 01:21
@ebranlard
Copy link
Contributor Author

ebranlard commented Dec 19, 2025

@ebranlard Has the sphere unit test been added already, or is that still to be completed?

The r-test for the potential flow about a sphere is now added, see here

@andrew-platt
Copy link
Collaborator

One of the regression tests is failing due to an incomplete preceding test (restart case). This is unrelated to the changes here.

Copy link
Collaborator

@jjonkman jjonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments and updating the acknowledgements!

@deslaughter deslaughter merged commit 45796c8 into OpenFAST:dev-tc Dec 19, 2025
13 checks passed
@ebranlard
Copy link
Contributor Author

Thank you for the fast turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants