Conversation
Collaborator
Author
|
@mfairborn23 Please add whatever notes you took in our last meeting to the above summary (you can edit my post) It is nice to have the PR open so we can al track the files changed and exchange questions / suggestions using the in-line comments. It is clear it is a WIP - so no worries there. Let's open a separate branch for the kinetic modifications in fourfit.jl that put the kinetic terms into the stability calculation. I don't want this one to depend on that one or that one to have to wait if this one takes some more time. That one can use dummy kinetic matrices for now until we get this one merged. |
…lcuation in DCON)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the initial effort to convert the fortran Perturbed Equilibrium Nonambipolar TRansport Code (PENTRC) to julia.
The first take will aim at a fairly direct conversion. Some notes to keep in mind,
ODEProblemin DCON converted code).