SPLINES - REFACTOR - BicubicSpline evaluation via FastInterpolations ND API#146
Merged
logan-nc merged 1 commit intospline_migration_FastInterpolationsfrom Feb 8, 2026
Conversation
…e CubicInterpolantND for cleaner API
ebe413d to
a7f1c60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@logan-nc
FastInterpolations.jl v0.2.8 is released and now it provides the generic ND cubic spline APIs.
This is a small refactoring PR (using the new API) into your PR (spline_migration_FastInterpolations) to avoid unintentional conflicts, while you're working on it.
Summary
BicubicSpline.jlwith the newCubicInterpolantNDAPI from FastInterpolations.jl (requires >=v0.2.8)evaluate!,deriv1!,deriv2!now delegate toitp(query; deriv=...)gradient!,hessian!, hint-based search)Changes
itps::Vector{CubicInterpolantND}field, removeperiodic_x/y,_last_ix/iy_fill_derivatives_impl!(4 BC variants),_bicube_getco!,_find_interval,_bicubic_wrap_periodic,_make_extrap_bcfsx/fsy/fsxyfromnodal_derivs.partials>=0.2.8