Include start node when pulling workflows, plus options refactor #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Wow I thought this was going to take ages - but I think this is it! I want to run some manual QA tomorrow with openfnx:
I'll also check what integration tests are like for this stuff EDIT: I have integration tests for most of this, just a couple of manual tests and we good |
josephjclark
changed the title
josephjclark
added a commit
that referenced
this pull request
Jan 14, 2026
* runtime: update error message * changeset * Include start node when pulling workflows, plus options refactor (#1214) * runtime: support first-class start key * drop requirement for top level workflow key * project: refactor support for the start key * fix tests * fix an issue where input path isn't parsed correctly * cli: suppress adaptor warning when running a yaml file * new tests for running yaml files * fix more tests * handle options on a non-nested workflow yaml * Execute workflow through a project (#1216) * allow workflow to be executed directly through workspace * types * remove default job.js * changeset * integration test * another integration test * support credentials on workspace config * remove mock * project: better handling of start in workflow.yaml * apply credentials map * add integration test for execute + credetial map * fix test * remove unused test * format * go deep on input tests * throw if workflow not found * project: fix an issue loading alias for a v1 project * update v1 integration test * fix integration test * better credential map handling * fix test It was secretly failing all along * ensure collections and credential map can both be set * changesets * test tweak * more integration test tweaks * fix integration tests yet again Turns out test order is important, so it was passing with .only but failing en masse * change v2 test order * let -> const * update v2 test configuration uuids as numbers break things * yet another test fix * fix -o alias on output * versions: cli@1.12.0, worker@1.21.1 * fix output * add missing diff * restore env as an alias * restore pull --beta * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third attempt to set a
startkey on workflows when loading from app state.Fixes #1213 I think
Fixes #1204
This turns out to be quite a big deal because basically the handling of start and options just isn't so good.
So changes in this PR:
{ workflow, options }is now considered old hat and legacystartkey as first class citizenAI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Release branch checklist
Delete this section if this is not a release PR.
If this IS a release branch:
pnpm changeset versionfrom root to bump versionspnpm installpnpm changeset tagto generate tagsgit push --tagsTags may need updating if commits come in after the tags are first generated.