Remove link to non-existent index.css (all style is inline). Remove d… #32
Conversation
…eprecated "style type". Correct "bugs" url in package.json and bump version number.
|
I see that the live site responds to |
| <script src="./index.js" type="text/javascript"></script> | ||
| <link rel="stylesheet" href="./index.css"> | ||
| <style type="text/css"> | ||
| <style> |
There was a problem hiding this comment.
This repository does function locally. You need to run npm start rather than opening the checked-in index.html directly in the browser.
esbuild generates https://embed.openhistoricalmap.org/index.css by concatenating any CSS file required by JavaScript (plus any CSS files we manually specify). Currently, all that we require is MapLibre’s stylesheet, so that’s all it contains:
openhistoricalmap-embed/index.js
Line 3 in 63c575b
We could split the inline stylesheet into an index.css (so that it resolves to something locally), then either add it to the esbuild command (so that it gets concatenated with MapLibre’s stylesheet) or require it in index.js.
| "license": "CC0-1.0", | ||
| "bugs": { | ||
| "url": "https://github.com/OpenHistoricalMap/openhistoricalmap-embed/issues" | ||
| "url": "https://github.com/OpenHistoricalMap/issues/issues" |
…eprecated "style type". Correct "bugs" url in package.json and bump version number.