Conversation
tonygermano
reviewed
Apr 3, 2025
Member
There was a problem hiding this comment.
Not making this a requirement to merge, but I'd like to see:
- an issue opened for the signing changes to build.xml
- the PR squashed to 2 commits, one for each issue
- the singing usage in this PR description added to the body of the commit message for the changes to build.xml
- a brief summary of the design of the github action, including the answer to my question about the two build steps, added to the body of the commit message for the addition of that file.
.github/workflows/build.yaml
Outdated
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: oie-build | ||
| path: openintegrationengine.tar.gz No newline at end of file |
Member
There was a problem hiding this comment.
missing a newline at the end of the file
jonbartels
requested changes
Apr 3, 2025
Signed-off-by: Kaur Palang <kaur.palang@brightcodecompany.com>
…ertificate - To disable signing altogether the `disableSigning` property should be set to `true`. This can be done by appending `-DdisableSigning=true` to the `ant` command - To sign with the bundled self-signed certificate, no additional properties need to be set - To sign with a CA signing certificate, append `-Dcert=ca` and `Dkeystore_property_file=/path/to/keystore.properties` Signed-off-by: Kaur Palang <kaur.palang@brightcodecompany.com>
kpalang
force-pushed
the
feature/#11_add-build-workflows
branch
from
38e7118 to
2dc47fe
Compare
tonygermano
approved these changes
Apr 4, 2025
Member
tonygermano
left a comment
tonygermano
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for putting in the requested changes.
Contributor
Author
|
@jonbartels I need your review here, too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added the some properties to control how the build is signed.
disableSigningproperty should be set totrue. This can be done by appending-DdisableSigning=trueto theantcommand-Dcert=caandDkeystore_property_file=/path/to/keystore.propertiesCA certificate signing options are highly specific to one's CA. I've customized the current setup to work with BrightCodeCompany's certificate, as it will be used for the first couple OIE releases.
Closes #11 #16