Issue #88 remove SimpleSender#163
Issue #88 remove SimpleSender#163jonbartels wants to merge 1 commit intoOpenIntegrationEngine:mainfrom
Conversation
Signed-off-by: Jon Bartels <jon.bartels@teladochealth.com>
jonbartels
force-pushed
the
issue-88-remove-simple-sender
branch
from
4698bfd to
598ddb1
Compare
jonbartels
requested review from
a team,
gibson9583,
kayyagari,
kpalang,
pacmano1,
ssrowe and
tonygermano
and removed request for
a team
|
If I had to guess, I'd say this probably serves some purpose for integration testing. |
|
@tonygermano There are no references to it in the code or tests that OpenIntegrationEngine has. I dug pretty deep when I filed #88 . Even if this class is used for integration testing or has some hidden reflective call it's very old code, that drags in an ancient JDBC JAR. The references I found date back to Mirth® 1.6! |
tonygermano
left a comment
tonygermano
left a comment
There was a problem hiding this comment.
@jonbartels I meant to assist with testing against a running mirth server. Remember there are also a lot of tests we don't run automatically because they require a running mirth server, and we don't know exactly how those tests were used internally at NG either.
Regardless, this PR is a duplicate of #96
|
Closing as duplicate |
4 participants
Resolves #88
The
simplesendermodule is never used. There were also references to it in.gitignorethat I removed.