AutoClosable Client

[tonygermano]

Commit 1

Make several private fields final in Client

These fields are all either initialized in their declarations or in the
constructor and then never reassigned.

Commit 2

Make Client AutoCloseable and close() idempotent

- Make AutoClosable so it can be used in try-with-resources
- Removed null check for serverConnection since it cannot be null
- Do not shutdown serverConnection or close JAX-RS client if this client
  is already closed.

[mgaffigan]

I love boring refactors!

[kayyagari]

Yay, "I reviewed it' ;).

[Copilot]

Pull request overview

This pull request enhances the Client class by making it AutoCloseable and improving immutability through making several fields final. The changes enable the Client to be used with try-with-resources statements while ensuring thread-safe, idempotent resource cleanup.

Key changes:

• Made five private fields (logger, serverConnection, client, api, closed) final to prevent reassignment
• Implemented the AutoCloseable interface to support try-with-resources usage
• Enhanced the close() method to be idempotent and thread-safe using atomic operations

Comments suppressed due to low confidence (1)

server/src/com/mirth/connect/client/core/Client.java:325

• The new AutoCloseable functionality and idempotent close() implementation lack test coverage. Consider adding tests to verify:

1. Multiple calls to close() are safe and only shutdown resources once
2. Client can be used with try-with-resources
3. Calling close() properly shuts down both serverConnection and the JAX-RS client

    @Override
    public void close() {
        if (!closed.getAndSet(true)) {
            serverConnection.shutdown();
            client.close();
        }
    }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[jonbartels]

LGTM #modernJava