Update WordUtils from deprecated version#48
Update WordUtils from deprecated version#48tonygermano merged 1 commit intoOpenIntegrationEngine:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates all usages of WordUtils from the deprecated org.apache.commons.lang3.text package (deprecated since commons-lang3 v3.6) to the recommended org.apache.commons.text package. The change is necessary as the project is using commons-lang3 v3.13.0, and the deprecated API should be replaced with the supported version.
- Updates 20 Java files to import
WordUtilsfromorg.apache.commons.textinstead of the deprecatedorg.apache.commons.lang3.textpackage - Ensures compatibility with the currently used commons-lang3 v3.13.0 library
- Leverages existing commons-text-1.10.0.jar already present in all affected modules (server, donkey, and client)
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| server/src/com/mirth/connect/util/CodeTemplateUtil.java | Updates WordUtils import for code template utility methods |
| server/src/com/mirth/connect/userutil/ContentType.java | Updates WordUtils import for content type enum string formatting |
| server/src/com/mirth/connect/server/userutil/DeployedState.java | Updates WordUtils import for deployed state enum formatting |
| server/src/com/mirth/connect/plugins/rulebuilder/RuleBuilderRule.java | Updates WordUtils import for rule builder functionality |
| server/src/com/mirth/connect/plugins/destinationsetfilter/DestinationSetFilterStep.java | Updates WordUtils import for destination filter step |
| server/src/com/mirth/connect/model/codetemplates/ContextType.java | Updates WordUtils import for context type enum |
| server/src/com/mirth/connect/model/codetemplates/CodeTemplate.java | Updates WordUtils import for code template model |
| server/src/com/mirth/connect/model/codetemplates/BasicCodeTemplateProperties.java | Updates WordUtils import for basic template properties |
| server/src/com/mirth/connect/model/DatabaseTask.java | Updates WordUtils import for database task model |
| server/src/com/mirth/connect/connectors/http/HttpStaticResource.java | Updates WordUtils import for HTTP static resource |
| server/src/com/mirth/connect/connectors/doc/PageSize.java | Updates WordUtils import for page size enum |
| donkey/src/main/java/com/mirth/connect/donkey/model/message/ContentType.java | Updates WordUtils import for donkey content type enum |
| donkey/src/main/java/com/mirth/connect/donkey/model/event/MessageEventType.java | Updates WordUtils import for message event type enum |
| donkey/src/main/java/com/mirth/connect/donkey/model/event/ErrorEventType.java | Updates WordUtils import for error event type enum |
| donkey/src/main/java/com/mirth/connect/donkey/model/event/DeployedStateEventType.java | Updates WordUtils import for deployed state event type enum |
| donkey/src/main/java/com/mirth/connect/donkey/model/event/ConnectionStatusEventType.java | Updates WordUtils import for connection status event type enum |
| donkey/src/main/java/com/mirth/connect/donkey/model/channel/DeployedState.java | Updates WordUtils import for donkey deployed state enum |
| client/src/com/mirth/connect/client/ui/editors/filter/IteratorRulePanel.java | Updates WordUtils import for iterator rule panel UI component |
| client/src/com/mirth/connect/client/ui/editors/BaseEditorPane.java | Updates WordUtils import for base editor pane UI component |
| client/src/com/mirth/connect/client/ui/dependencies/ChannelDependenciesWarningDialog.java | Updates WordUtils import for channel dependencies warning dialog |
The changes are well-executed and consistent across all files. The PR successfully migrates from deprecated API to the supported commons-text package, with the necessary library already present in all affected modules.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR updates all usages of WordUtils from the deprecated org.apache.commons.lang3.text package (deprecated since commons-lang3 v3.6) to the recommended org.apache.commons.text package. The change is necessary as the project is using commons-lang3 v3.13.0, and the deprecated API should be replaced with the supported version. - Updates 20 Java files to import WordUtils from org.apache.commons.text instead of the deprecated org.apache.commons.lang3.text package - Ensures compatibility with the currently used commons-lang3 v3.13.0 library - Leverages existing commons-text-1.10.0.jar already present in the server and client sub-projects and adds the same library to the donkey sub-project Signed-off-by: Richard Ogin <rogin@users.noreply.github.com>
c05cbfe to
33db9bb
Compare
Usage of
WordUtilswas showing as deprecated.Code was using
WordUtilsfrom common-lang3 jar where it became deprecated at v3.6 (we're using v3.13). This change usesWordUtilsfrom commons-text as recommended. As third party libs aren't shared across subprojects, I had to duplicate the commons-text jar under donkey/lib/commons/.