Closed
Conversation
Member
|
I haven't had a chance to do a thorough review yet, but I wanted to point out a small change in #60 so you didn't miss it. |
Collaborator
Author
|
Everything compiles, but tests still fail. |
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
webdavclient4j does not include .lib Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Tests are failing (missing deps) Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Not running, cause of version.properties Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
…change Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Tests fail Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Removes references to `build.properties` and related variables. These properties are no longer needed, simplifying the build configuration. Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
This commit updates the build configuration files to align with a Gradle upgrade. It configures duplicate strategy to exclude for Jar, Tar, and Zip tasks. Removes unnecessary source set configurations and test configurations in build.gradle files. Renames packages for test java classes in server module to align with the new structure. Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Updates the server's dependency on the donkey project to use the default artifact publication instead of explicitly specifying the 'default' configuration. This streamlines the dependency declaration. Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Tony Germano <tony@germano.name> Signed-off-by: Nico Piel <nico.piel@hotmail.de>
engine.vmoptions in the basedir now only has includes for the following three files: /conf/base_includes.vmoptions contains the default options for all runs as of mirth 4.5.2. /conf/default_modules.vmoptions contains the java 9+ options as of 4.5.2. /conf/custom.vmoptions is empty other than usage instructions and is the target for user changes Signed-off-by: Tony Germano <tony@germano.name> Signed-off-by: Nico Piel <nico.piel@hotmail.de>
NicoPiel
force-pushed
the
feature/gradle
branch
from
5fc1966 to
cc8983f
Compare
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Migrates the server build process away from Ant.
Collaborator
Author
|
Project builds and outputs original dir structure (mostly). Server doesn't start yet. |
Signed-off-by: Nico Piel <nicopiel@mailbox.org>
Signed-off-by: Nico Piel <nicopiel@mailbox.org>
jbeckers
reviewed
May 20, 2025
There was a problem hiding this comment.
Any reason you didn't go with the kotlin style build.gradle.kts?
IMHO it should be the default for any new project, the tooling support is so much better!
Collaborator
Author
There was a problem hiding this comment.
No reason at all. But good catch. I'll convert them :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've started working on migrating OIE from Ant to Gradle.
To test, run
./gradlew clean build -x test(tests are failing)
Fixes #52