[ana3;in3] add check for aimec new coordinate system #1225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
Contributor
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Files with Diff Coverage (3)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
fso42
requested changes
Dec 22, 2025
fso42
changed the title
fso42
force-pushed
the
checkAimecDomain
branch
from
9feb136 to
8ab6715
Compare
fso42
approved these changes
Dec 23, 2025
remove unused imports add pytest remove unused return variable
fso42
force-pushed
the
checkAimecDomain
branch
from
4c4ecaa to
e895c31
Compare
fso42
approved these changes
Jan 8, 2026
add parameter to ini file# only show warning add info in docs remove unused return var
fso42
force-pushed
the
checkAimecDomain
branch
from
3ec509c to
ebeaa3b
Compare
Contributor
|
Standardtests ident |
…findIntSectCoors` - Added tests for `checkOverlapDBXYWithData` to validate grid intersection detection with various scenarios, including no intersection, intersecting lines, and output shape verification. - Added tests for `findIntSectCoors` to validate intersection point indexing with test cases for single-point, tolerance-based, and out-of-grid scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the aimec analysis a new coordinate system is defined along the thalweg (avaDir/Inputs/LINES/path_aimec.shp). If the provided line has too much curvature, this can introduce overlapping parts (with respect to the original data in cartesian coordinates) in the new coordinate system.
In this PR, the introduced checks are:
Currently disabled check - requires more ressources:
5. if the 2. check shows overlapping regions and this coincides with regions where datafield != 0 (that is analysed) -> error and produce a plot indicating where the overlap ocurs
The second check would also cover errors of the first check, however it saves computational time if the first check already fails.