Conversation
Import the earlgrey Pigweed target definition. Signed-off-by: Chris Frantz <cfrantz@google.com>
|
Move the tooling and signing subdirectories into `//target/earlgrey` as they are specific to the earlgrey target. Signed-off-by: Chris Frantz <cfrantz@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR imports the pigweed target definitions for the OpenTitan Earlgrey chip.
/target/-type ignores from.gitignore. We'll have to consider how we want to handle this as we migrate this repo from being cargo-based to bazel-based. I'd be OK with renaming//target/ealrgreyto something else; this is currently the pigweed convention.//toolingand//signingsubdirs into//target/earlgrey. Both of these subdirectories have earlgrey-specific definitions and probably shouldn't live at the root of the repo.This is a draft PR initially meant to create some discussion. Namely: