Skip to content

Conversation

@Stef-Rousset
Copy link

@Stef-Rousset Stef-Rousset commented Jun 3, 2025

🎩 What? Why?

This PR updates flag modals to improve accessibility, by adding:

  • a fieldset and legend on radio buttons
  • a value to the for and id attributes on radio buttons
  • a value to the for and id attributes of the textarea

This PR is issued from the audit of Angers city (page 92 and 93), and corresponds to criterias 1.3.1 and 3.3.2 from WCAG

📌 Related Issues

Testing

  1. As a logged in user, go to a process, and then to proposals
  2. Find a proposal with comments and report one comment
  3. Right Click + "Inspect", and see in the html that the changes above are effective.

📷 Screenshots (optional)

Radio buttons
Capture d’écran 2025-06-03 à 10 31 17

Textarea
Capture d’écran 2025-06-03 à 10 00 17

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@Stef-Rousset Stef-Rousset force-pushed the fix/flag_modals_report branch from bb46f42 to 67a6db7 Compare June 4, 2025 13:38
@Stef-Rousset Stef-Rousset force-pushed the fix/flag_modals_report branch from 67a6db7 to eafcdd1 Compare June 9, 2025 07:23
@stale
Copy link

stale bot commented Oct 16, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. @carolromero & @xabier feel free to chime in.

@stale stale bot added the wontfix under the radar label Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants