Conversation
|
I generated a structure-diff below from pulling |
Author
|
Possibly of note: the issue with the incorrect MANIFEST for java-object-diff has a pending PR upstream to fix the root problem, cf. SQiShER/java-object-diff#206 |
Vogel612
force-pushed
the
fix/osgi-slf4j-issues
branch
from
8d8ae9c to
eb4a9fc
Compare
Export slf4j-logging deps for consumption by container. Update OSGi specs to deal with optional dependencies and incorrect MANIFEST files. Add variable to enable quick versioning changes to exported OSGi artifacts. Signed-off-by: Clemens Lieb <vogel612@gmx.de>
Vogel612
force-pushed
the
fix/osgi-slf4j-issues
branch
from
eb4a9fc to
a7102bb
Compare
|
Please raise this PR in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed slf4j-ext from winery, replacing usages of XLogger with usages of Logger.
Also explicitly export slf4j dependencies to OSGi consumers in the version used in winery.
Additional fixes include corrections to some incorrect MANIFEST.MF files (de.danielbechler:java-object-diff).
This fixes the remainder of issues encountered with OSGi
Reviews are highly appreciated.