Skip to content

[Hackathon] add basic xss template#108

Open
wbowling wants to merge 2 commits intoOpenToAllCTF:masterfrom
wbowling:xss-template
Open

[Hackathon] add basic xss template#108
wbowling wants to merge 2 commits intoOpenToAllCTF:masterfrom
wbowling:xss-template

Conversation

@wbowling
Copy link
Contributor

Used for a few upcoming challenges, might be useful to have as a template

Copy link
Contributor

@Grazfather Grazfather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just style issues.


@app.route("/")
async def index():
query = parse_qs(request.query_string)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 space indents for this whole file

import secrets
import asyncio

from urllib.parse import parse_qs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pep8 groupings. Put stdlib in one grouping at the top (even if from...), then 3rd party, then local libs

pass

async def start_browser(url):
browser = await launch(**chromium_path(), args=["--no-sandbox"])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line stopped working on the ota vps, not sure why as it works locally in docker and on my vps. Changing it to just browser = await launch(args=["--no-sandbox"]) fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants