Don't use wait for host port instead use pg_isready #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianrakel
force-pushed
the
fix-postgres-online-check
branch
from
97488df to
472f168
Compare
bastelfreak
previously approved these changes
Dec 28, 2025
ekohl
reviewed
Dec 28, 2025
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Perhaps also drop the wait_for_host_name_resolution and wait_for_host_port functions? Then you can drop dnsutils and netcat-openbsd because they're unused.
sebastianrakel
force-pushed
the
fix-postgres-online-check
branch
from
472f168 to
2d58f5a
Compare
Contributor
Author
done |
bastelfreak
approved these changes
Dec 28, 2025
ekohl
reviewed
Dec 28, 2025
| # wait for postgres DNS | ||
| wait_for_host_name_resolution $OPENVOXDB_POSTGRES_HOSTNAME $OPENVOXDB_WAITFORHOST_SECONDS | ||
| # wait for postgres is ready | ||
| /wtfc.sh --timeout="${OPENVOXDB_WAITFORHOST_SECONDS}" --interval=1 --progress "pg_isready -h ${OPENVOXDB_POSTGRES_HOSTNAME} --port '${OPENVOXDB_POSTGRES_PORT:-5432}'" |
There was a problem hiding this comment.
Should this be using OPENVOXDB_WAITFORPOSTGRES_SECONDS and then drop OPENVOXDB_WAITFORHOST_SECONDS?
| # wait for postgres is ready | ||
| /wtfc.sh --timeout="${OPENVOXDB_WAITFORHOST_SECONDS}" --interval=1 --progress "pg_isready -h ${OPENVOXDB_POSTGRES_HOSTNAME} --port '${OPENVOXDB_POSTGRES_PORT:-5432}'" | ||
|
|
||
| # wait for puppetserver DNS, then healthcheck |
ekohl
reviewed
Dec 28, 2025
| org.label-schema.vcs-ref="$vcs_ref" \ | ||
| org.label-schema.build-date="$build_date" | ||
|
|
||
| # Use netcat-openbsd to support IPv6 connectivity checks (netcat-traditional is IPv4 only) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also removed the host/dns check for openvoxserver. i don't think it's needed because the curl command will implicit do the same
this will fix #60