remove .lower() call when generating in-file timestamp#9
Open
elementc wants to merge 1 commit intoOsndok:masterfrom
Open
remove .lower() call when generating in-file timestamp#9elementc wants to merge 1 commit intoOsndok:masterfrom
elementc wants to merge 1 commit intoOsndok:masterfrom
Conversation
Owner
|
Yeah... the "tolower()" was a hack to support Windows, because they don't have the "lowercase am/pm" format variable. I'd still like to keep the default behavior, so I'll poke at this and see if I can select a different default format string based on OS (so just windows will get the capital AM/PM). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For test logging purposes at work, I need to insert the timezone into my timestamps (via the strftime %Z operator). As written, the lower() call converts these stamps to lowercase- for instance, while I expect the format string "%H:%M:%S %Z" to produce "16:04:36 PDT", it actually produces "16:04:36 pdt". This is inconsistent with other zim timestamps which do not change the case of alphabetical letters in generated timestamps.
This fix corrects this oversight and brings us closer to the existing Zim behavior. You may also wish to look into these potentially unnecessary semicolons in a later revision :)