Fix main signature to match control flow and harden CLI path tests#79
Merged
jonathanmagambo merged 1 commit intoOttrlang:mainfrom Jan 19, 2026
Merged
Fix main signature to match control flow and harden CLI path tests#79jonathanmagambo merged 1 commit intoOttrlang:mainfrom
jonathanmagambo merged 1 commit intoOttrlang:mainfrom
Conversation
Collaborator
|
thank you so much |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes two small but important correctness fixes without changing behavior.
First, main no longer advertises a Result return type while unconditionally terminating the process on errors. Since the error path always calls process::exit, the function never returns Err, so the previous signature was basically misleading. The updated signature reflects the actual control flow and avoids implying Rust-managed error propagation that never happens.
Second, the CLI test assertions were tightened to avoid string-based path comparisons. The test now compares Path values directly, removing assumptions about UTF-8 encoding and path formatting while keeping the same intent and coverage.