Skip to content

Fix main signature to match control flow and harden CLI path tests#79

Merged
jonathanmagambo merged 1 commit intoOttrlang:mainfrom
LqauzDev:main
Jan 19, 2026
Merged

Fix main signature to match control flow and harden CLI path tests#79
jonathanmagambo merged 1 commit intoOttrlang:mainfrom
LqauzDev:main

Conversation

@LqauzDev
Copy link
Contributor

This PR makes two small but important correctness fixes without changing behavior.

First, main no longer advertises a Result return type while unconditionally terminating the process on errors. Since the error path always calls process::exit, the function never returns Err, so the previous signature was basically misleading. The updated signature reflects the actual control flow and avoids implying Rust-managed error propagation that never happens.

Second, the CLI test assertions were tightened to avoid string-based path comparisons. The test now compares Path values directly, removing assumptions about UTF-8 encoding and path formatting while keeping the same intent and coverage.

@jonathanmagambo jonathanmagambo merged commit 700b41b into Ottrlang:main Jan 19, 2026
3 checks passed
@jonathanmagambo
Copy link
Collaborator

thank you so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants