Skip to content

Conversation

@ohnorobo
Copy link
Contributor

Added instructions for installing Rosetta on M4/M5 Macs.

Added instructions for installing Rosetta on M4/M5 Macs.
@ohnorobo ohnorobo requested a review from a team as a code owner January 13, 2026 14:33
@ohnorobo ohnorobo requested a review from fortuna January 13, 2026 14:34
@ohnorobo ohnorobo enabled auto-merge (squash) January 13, 2026 14:37
@ohnorobo ohnorobo changed the title build(client): Update electron README with Rosetta installation instructions build(client): update electron README with Rosetta installation instructions Jan 13, 2026
@ohnorobo ohnorobo requested a review from fortuna January 13, 2026 17:16
@ohnorobo ohnorobo requested a review from jyyi1 January 16, 2026 12:16
@ohnorobo
Copy link
Contributor Author

@jyyi1 I'll need you to actually click "approve" before I can merge.

Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the question on why we need Rosetta

@ohnorobo
Copy link
Contributor Author

The failure was in our windows client build

  ▶ action(client/electron/build_main): 🎉 Success! (6854ms)
    • electron-builder  version=23.6.0 os=25.2.0
    • description is missed in the package.json  appPackageFile=/Users/laplante/Projects/outline-apps/package.json
    • author is missed in the package.json  appPackageFile=/Users/laplante/Projects/outline-apps/package.json
    • packaging       platform=win32 arch=ia32 electron=19.1.9 appOutDir=output/client/electron/build/win-ia32-unpacked
    • downloading     url=https://github.com/electron/electron/releases/download/v19.1.9/electron-v19.1.9-win32-ia32.zip size=84 MB parts=8
    • downloaded      url=https://github.com/electron/electron/releases/download/v19.1.9/electron-v19.1.9-win32-ia32.zip duration=3.277s
    • downloading     url=https://github.com/electron-userland/electron-builder-binaries/releases/download/winCodeSign-2.6.0/winCodeSign-2.6.0.7z size=5.6 MB parts=1
    • downloaded      url=https://github.com/electron-userland/electron-builder-binaries/releases/download/winCodeSign-2.6.0/winCodeSign-2.6.0.7z duration=2.547s
    • downloading     url=https://github.com/electron-userland/electron-builder-binaries/releases/download/wine-4.0.1-mac/wine-4.0.1-mac.7z size=19 MB parts=3
    • downloaded      url=https://github.com/electron-userland/electron-builder-binaries/releases/download/wine-4.0.1-mac/wine-4.0.1-mac.7z duration=2.594s
    ⨯ cannot execute  cause=fork/exec /Users/laplante/Library/Caches/electron-builder/wine/wine-4.0.1-mac/bin/wine64: bad CPU type in executable
                      command=/Users/laplante/Library/Caches/electron-builder/wine/wine-4.0.1-mac/bin/wine64 /Users/laplante/Library/Caches/electron-builder/winCodeSign/winCodeSign-2.6.0/rcedit-x64.exe /Users/laplante/Projects/outline-apps/output/client/electron/build/win-ia32-unpacked/Outline.exe --set-version-string FileDescription Outline --set-version-string ProductName Outline --set-version-string LegalCopyright 'Copyright © 2026 Outline' --set-file-version 0.0.0-debug --set-product-version 0.0.0.0 --set-version-string InternalName Outline --set-version-string OriginalFilename '' --set-icon /Users/laplante/Projects/outline-apps/client/electron/icons/win/icon.ico

electron-builder is apparently using an old intel version of wine to do some code signing for the .exe

I just wanted to add a few lines to the readme to save some future developer from having to debug the same issue again to get the build working. I don't think it's really worth digging into the internals of our electron build to resolve a build issue that otherwise has an simple workaround.

@jyyi1
Copy link
Contributor

jyyi1 commented Jan 16, 2026

electron-builder is apparently using an old intel version of wine to do some code signing for the .exe

I just wanted to add a few lines to the readme to save some future developer from having to debug the same issue again to get the build working. I don't think it's really worth digging into the internals of our electron build to resolve a build issue that otherwise has an simple workaround.

Yes, I can confirm Rosetta is installed on my machine (though I didn't explicitly install it before); maybe it's auto-installed by Google.

> pkgutil --pkg-info com.apple.pkg.RosettaUpdateAuto 

package-id: com.apple.pkg.RosettaUpdateAuto
version: 1.0.0.0.1.1763815964
volume: /
location: /
install-time: 1766174004

Clarify the need for Rosetta installation on M-series ARM Macs due to a code-signing step in the Windows build.
@ohnorobo
Copy link
Contributor Author

Updated the readme further to indicate exactly which build step requires rosetta.

@ohnorobo ohnorobo dismissed fortuna’s stale review January 20, 2026 11:16

Added more info to the readme indicating this is required for wine usage in our windows build.

@ohnorobo ohnorobo merged commit f270481 into master Jan 20, 2026
23 checks passed
@ohnorobo ohnorobo deleted the m5-patch branch January 20, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants