-
Notifications
You must be signed in to change notification settings - Fork 1.4k
build(client): update electron README with Rosetta installation instructions #2696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added instructions for installing Rosetta on M4/M5 Macs.
|
@jyyi1 I'll need you to actually click "approve" before I can merge. |
fortuna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the question on why we need Rosetta
|
The failure was in our windows client build electron-builder is apparently using an old intel version of wine to do some code signing for the .exe I just wanted to add a few lines to the readme to save some future developer from having to debug the same issue again to get the build working. I don't think it's really worth digging into the internals of our electron build to resolve a build issue that otherwise has an simple workaround. |
Yes, I can confirm Rosetta is installed on my machine (though I didn't explicitly install it before); maybe it's auto-installed by Google. > pkgutil --pkg-info com.apple.pkg.RosettaUpdateAuto
package-id: com.apple.pkg.RosettaUpdateAuto
version: 1.0.0.0.1.1763815964
volume: /
location: /
install-time: 1766174004 |
Clarify the need for Rosetta installation on M-series ARM Macs due to a code-signing step in the Windows build.
|
Updated the readme further to indicate exactly which build step requires rosetta. |
Added more info to the readme indicating this is required for wine usage in our windows build.
Added instructions for installing Rosetta on M4/M5 Macs.