Skip to content

Remove misleading optional annotations from BeaconBooleanResponse fields#5

Merged
iimpulse merged 2 commits intoenhancement/model-syncfrom
copilot/sub-pr-4
Feb 11, 2026
Merged

Remove misleading optional annotations from BeaconBooleanResponse fields#5
iimpulse merged 2 commits intoenhancement/model-syncfrom
copilot/sub-pr-4

Conversation

Copy link
Contributor

Copilot AI commented Feb 11, 2026

The info and beacon_handovers fields in BeaconBooleanResponse were annotated as | None but used default_factory, meaning they're always initialized to empty collections and never None. This created misleading OpenAPI schemas and inconsistency with other response classes.

Changes:

  • Removed | None from info field type annotation (now dict[str, Any])
  • Removed | None from beacon_handovers field type annotation (now list[BeaconHandover])

Before:

info: dict[str, Any] | None = Field(default_factory=dict, ...)
beacon_handovers: list[BeaconHandover] | None = Field(default_factory=list, ...)

After:

info: dict[str, Any] = Field(default_factory=dict, ...)
beacon_handovers: list[BeaconHandover] = Field(default_factory=list, ...)

This aligns BeaconBooleanResponse with BeaconCountResponse, BeaconResultsetsResponse, and BeaconCollectionsResponse, which already follow this pattern.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: iimpulse <7397665+iimpulse@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 11, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • astral.sh
    • Triggering command: /usr/bin/curl curl -LsSf REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Address feedback on model sync enhancements Remove misleading optional annotations from BeaconBooleanResponse fields Feb 11, 2026
Copilot AI requested a review from iimpulse February 11, 2026 19:32
@iimpulse iimpulse marked this pull request as ready for review February 11, 2026 20:03
@iimpulse iimpulse merged commit 6b5897f into enhancement/model-sync Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants