DevelopAdding class to get CP candidate diseases#16
Conversation
ielis
left a comment
There was a problem hiding this comment.
Hi @pnrobinson
the CpCommand looks good to me. At the end, you will get the diseases with onset that overlaps with HPO's infantile or childhood onset period AND annotated by the terms listed at the top of the class, or their descendants AND with known disease-gene association.
It is not 100% clear to me why the diseases with Athetoid cerebral palsy are not dealt with (the lines are commented out), but I suppose you have your reasons.
I am not sure if I should have a look at the other classes. DiseaseSetCommand has a weird command name (mondo), so you probably never ran it? The changes in SimulatedHpoDiseaseGenerator also look like leftovers from another feature.. 🤔
Moreover, I am not sure why are you merging from develop -> main. This is not the typical feature workflow.. 🤔
No description provided.