Skip to content

DevelopAdding class to get CP candidate diseases#16

Open
pnrobinson wants to merge 5 commits intomainfrom
develop
Open

DevelopAdding class to get CP candidate diseases#16
pnrobinson wants to merge 5 commits intomainfrom
develop

Conversation

@pnrobinson
Copy link
Collaborator

No description provided.

@pnrobinson pnrobinson requested a review from ielis December 3, 2025 14:13
Copy link

@ielis ielis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pnrobinson

the CpCommand looks good to me. At the end, you will get the diseases with onset that overlaps with HPO's infantile or childhood onset period AND annotated by the terms listed at the top of the class, or their descendants AND with known disease-gene association.

It is not 100% clear to me why the diseases with Athetoid cerebral palsy are not dealt with (the lines are commented out), but I suppose you have your reasons.

I am not sure if I should have a look at the other classes. DiseaseSetCommand has a weird command name (mondo), so you probably never ran it? The changes in SimulatedHpoDiseaseGenerator also look like leftovers from another feature.. 🤔

Moreover, I am not sure why are you merging from develop -> main. This is not the typical feature workflow.. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants