Draft
Conversation
- Add VMCache class for caching VM information - Add node caching with TTL - Cache VM locations and status - Update cache on VM state changes - Reduce API calls in get_node_by_vmid and update_state - Clear cache entries when VMs are deleted Fixes #2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements caching to reduce the number of requests to the Proxmox API as requested in #2.
Changes Made
VMCacheclass to handle VM information caching with TTLget_node_by_vmidandupdate_statemethodsclear_cachesmethod for manual cache invalidationImplementation Details
Testing
The caching system has been tested with the following scenarios:
Fixes #2