Bug Fix - Jasperstarter LF Line Endings#354
Open
Biele10 wants to merge 2 commits intoPHPJasper:masterfrom
Open
Bug Fix - Jasperstarter LF Line Endings#354Biele10 wants to merge 2 commits intoPHPJasper:masterfrom
Biele10 wants to merge 2 commits intoPHPJasper:masterfrom
Conversation
added 2 commits
January 30, 2026 10:30
…er to prevent CRLF replacing LF. Tested both on Windows and Linux and the code worked correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was encountering a bug when using the library where on my WSL server the jasperstarter file was not being found. Due to CRLF line endings, the shell script failed to execute on Linux systems. To fix this I ran
dos2unix ./jasperstarterwhich updated the file to use LF line endings rather than CRLF ones.I would recommend testing yourself on Windows and on Linux, I found that they both ran fine (as expected) but of course feel free to test it yourself, don't just take my word for it 😅.
I have updated the jasperstarter file to now have LF line endings and added a gitattribute file to ensure it stays that way. (Not sure why but Git changes LF file endings to use CRLF when committing unless explicitly stated NOT to in the .gitattribute.)
Hope this helps.
Any questions/issues, please let me know. :)