Update radiation_models.rst #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected spherical shielding description for SHIELDOSE2: it is not illuminated from all directions, only one hemisphere.
AntoineBrunet
approved these changes
Apr 30, 2025
Contributor
AntoineBrunet
left a comment
AntoineBrunet
left a comment
There was a problem hiding this comment.
The PR looks fine to me. I trust Paul on this, and it seems to match the output variable description which appears later:
SolDose: dose profile for solar protons (rads)
1. Dose in semi-infinite aluminium medium
2. Dose at transmission surface of finite aluminium slab shields
3. 1/2 Dose at center of aluminium spheres
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected spherical shielding description for SHIELDOSE2: it is not illuminated from all directions, only one hemisphere.
Pull Request Checklist
New code is easier to review, integrate and maintain if it's
clear, commented, and consistent with the style of the rest
of the IRBEM code.
Please try to follow as much of this checklist as you can for
your PR. If you can't hit everything, or don't know how to,
then submit the PR and the rest can be discussed during review.
Some additional suggestions are given below.
Please also see our Code of Conduct so that the PRBEM community
remains welcoming and inclusive.
Go ahead and replace the text above (and this line!) with your
pull request description.
See issue #orCloses #)