add type-hints vacancy #312
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix required skills
Присвоение одной специальности нескольким пользователям
Flexivanov237 pro 170
Лента, оценки и куча куча багов
added correct dates to feed
yakser
requested changes
Mar 22, 2024
Member
yakser
left a comment
yakser
left a comment
There was a problem hiding this comment.
тесты упали
линтеры упали
куски кода какие то удалены, как будто случайно половину файлов поудалял
vacancy/filters.py
Outdated
|
|
||
|
|
||
| def project_id_filter(queryset, name, value): | ||
| def project_id_filter(queryset, name, value) -> queryset: |
Member
There was a problem hiding this comment.
оно точно работает?
кажется тут должен быт QuerySet[Project] или что то такое
vacancy/filters.py
Outdated
| def __init__(self, *args, **kwargs): | ||
| """if is_active filter is not passed, default to True""" | ||
| super().__init__(*args, **kwargs) | ||
| super().init(*args, **kwargs) |
| class VacancyResponseDetailSerializer(serializers.ModelSerializer[VacancyResponse]): | ||
| user = UserDetailSerializer(many=False, read_only=True) | ||
| vacancy = VacancyListSerializer(many=False, read_only=True) | ||
| is_approved = serializers.BooleanField(read_only=True) |
vacancy/serializers.py
Outdated
|
|
||
| class VacancyResponseAcceptSerializer(VacancyResponseDetailSerializer): | ||
| is_approved = serializers.BooleanField(required=True, read_only=False) | ||
| is_approve |
yakser
requested changes
Apr 6, 2024
|
|
||
| class VacancyDetailSerializer( | ||
| serializers.ModelSerializer, RequiredSkillsWriteSerializerMixin | ||
| serializers.ModelSerializer, RequiredSkillsWriteSerializerMixin[Vacancy] |
vacancy/serializers.py
Outdated
|
|
||
|
|
||
| class RequiredSkillsWriteSerializerMixin(RequiredSkillsSerializerMixin): | ||
| class RequiredSkillsWriteSerializerMixin(RequiredSkillsSerializerMixin[Project]): |
Member
There was a problem hiding this comment.
это миксин, тут не нужен тайпхинт потому что модели разные могут быть
vacancy/serializers.py
Outdated
|
|
||
| class ProjectVacancyListSerializer( | ||
| serializers.ModelSerializer, RequiredSkillsSerializerMixin | ||
| serializers.ModelSerializer, RequiredSkillsSerializerMixin[Project] |
vacancy/serializers.py
Outdated
|
|
||
| class ProjectVacancyCreateListSerializer( | ||
| serializers.ModelSerializer, RequiredSkillsWriteSerializerMixin | ||
| serializers.ModelSerializer, RequiredSkillsWriteSerializerMixin[Project] |
Contributor
|
Пиши, пожалуйста, более осознанные названия комитов, они потом в общей истории будут |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.