fix: python3 compatibility and rocky8 packaging#181
Open
hussainbani wants to merge 2 commits intoPagerDuty:masterfrom
Open
fix: python3 compatibility and rocky8 packaging#181hussainbani wants to merge 2 commits intoPagerDuty:masterfrom
hussainbani wants to merge 2 commits intoPagerDuty:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the build and packaging system to move from CentOS 7 to Rocky Linux 8 (a CentOS 8 successor), modernizes the Docker and build scripts, and improves compatibility with newer Ruby and Python versions. These changes ensure continued support and easier maintenance by using more up-to-date base images and tools. The most important changes are grouped below:
Migration to Rocky Linux 8 and Modernization of Docker Build:
Dockerfile-centos-7(CentOS 7) with a newDockerfile-centosbased onrockylinux:8, updated to use Ruby 3 and newer FPM and Python versions, and simplified the build steps. [1] [2]Makefileto use the newDockerfile-centosfor CentOS builds.build-linux/make_common.env.Packaging Script Improvements:
build-linux/make_package.shto use the system Ruby and FPM for Rocky 8+, and added a check to warn if GPG signing keys are not set up, building unsigned packages in that case. [1] [2]build-linux/make_rpm.shto create required directories if they do not exist, making the script more robust.Python Path Handling and Versioning:
pdagent/__init__.pyfrom 1.7.4 to 1.8.0.