feat/callrepo-for-crudmethods by DevamPatel22 · Pull Request #40 · Pairadux/lapse

DevamPatel22 · 2026-02-11T23:56:30Z

No description provided.

Pairadux · 2026-02-12T18:43:41Z

Haven't reviewed the files yet, but I do have a note before starting. Please try to use conventional commit messages going forward. Use this reference document as necessary, ask questions if you need to: Conventional Commits Website. The same goes for PR titles.

Pairadux · 2026-02-12T18:45:02Z

test/widget_test.dart

Remove the changes made to this file, this falls outside of your scope.

Pairadux · 2026-02-12T18:45:21Z

lib/features/study/presentation/screens/study_session_screen.dart

Remove the changes made to this file, this falls outside of your scope.

Pairadux · 2026-02-12T18:45:29Z

lib/features/decks/presentation/screens/deck_list_screen.dart

Remove the changes made to this file, this falls outside of your scope.

Pairadux · 2026-02-12T18:45:58Z

lib/features/decks/data/deck_repository.dart

Remove this file so we don't have merge conflicts later.

Pairadux · 2026-02-12T18:46:15Z

lib/features/decks/domain/deck.dart

Remove the changes made to this file, this falls outside of your scope. This was already implemented by Germaine.

Pairadux · 2026-02-12T18:46:27Z

lib/features/decks/presentation/data/deck_repository.dart

Remove this file to avoid merge conflicts later.

Pairadux · 2026-02-12T18:46:39Z

lib/features/decks/presentation/data/deck_repository_provider.dart

Remove this file to avoid merge conflicts later.

Pairadux · 2026-02-12T18:49:41Z

Also, please ref issues that your commits are tackling, or if the entire PR is to close an issue, ref that in the header please.

Pairadux · 2026-02-12T19:04:24Z

I have just reviewed all of the code, here are few high-level things that need to be addressed before this can be merged:

You need to be using the modern Riverpod APIs. Most of the providers I saw use StateNotifier / StateNotifierProvider from flutter_riverpod/legacy.dart, which is the deprecated version of the riverpod package. Use Notifier / AsyncNotifier instead. You have this setup like this in deck_list_provider.dart, so use that as a reference to fix the rest of them.
Use the existing application services. You may need to pull main for this, but in study_session_provider.dart you re-implement the card scheduling from scratch with hard-coded intervals. We already have FsrsService and StudySessionService in lib/features/study/application/ that handle this properly, plus a StudySession domain model in lib/features/study/domain/. The provider should wrap those, not replace them.
Repository classes don't belong in presentation/Providers/. Interfaces, implementations, and seed data are data-layer concerns. They should live in data/, but I am taking care of most of that in my scope. The Providers/ directory should only have Riverpod provider definitions. Also, directory should be lowercase providers/ per dart convention.
Please remove the out-of-scope files that I mentioned above.

Pairadux · 2026-02-12T19:06:28Z

lib/features/cards/presentation/Providers/card_repository_impl.dart

+  Future<void> deleteCard(String cardId) async {
+    final index = _cards.indexWhere((c) => c.cardID == cardId);
+    if (index != -1) {
+      _cards[index].isDeleted = true;


This will be a compile error. Flashcard fields are final. Use copyWith() instead.

Pairadux · 2026-02-12T19:07:28Z

lib/features/decks/presentation/Providers/deck_repository_impl.dart

+  Future<void> deleteDeck(String deckId) async {
+    final index = _decks.indexWhere((d) => d.deckID == deckId);
+    if (index != -1) {
+      _decks[index] = _decks[index].copyWith(isDeleted: true, deckName: '');


Why is deckName being cleared on delete? Soft deleting should only mark it as isDeleted which you are doing, it shouldn't destroy data.

Pairadux · 2026-02-12T19:08:27Z

lib/features/study/presentation/Providers/study_session_provider.dart

+    };
+  }
+
+  Flashcard _applyBasicScheduling(Flashcard card, Rating rating) {


This reimplements scheduling that already exists in FsrsService. Use the existing service instead of hardcoding intervals.