Skip to content

Fix node/panel image uninstall: avoid brittle parsing #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TaraRostami wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix node/panel image uninstall: avoid brittle parsing #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18bf1ed
fix: uninstall_node_docker_images
TaraRostami Feb 22, 2026
ca9a740
fix: uninstall_pasarguard_docker_images
TaraRostami Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions pasarguard.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3819,16 +3819,30 @@ uninstall_pasarguard() {
}

uninstall_pasarguard_docker_images() {
images=$(docker images | grep pasarguard | awk '{print $3}')
local images
images=$(docker images --format '{{.Repository}} {{.ID}}' | awk '$1 ~ /^pasarguard\/panel(:|$)/ {print $2}' | sort -u)

if [ -n "$images" ]; then
colorized_echo yellow "Removing Docker images of pasarguard"
for image in $images; do
if docker rmi "$image" >/dev/null 2>&1; then
colorized_echo yellow "Image $image removed"
fi
done
if [ -z "$images" ]; then
colorized_echo yellow "pasarguard/panel images not found"
return 0
fi

colorized_echo yellow "Checking pasarguard/panel images for removal..."

for image in $images; do
if docker ps -a --filter "ancestor=$image" -q | grep -q .; then
local container
container=$(docker ps -a --filter "ancestor=$image" --format '{{.Names}}' | tr '\n' ' ')
colorized_echo yellow "Skipping image $image (still used by: $container)"
continue
fi

if docker rmi "$image" >/dev/null 2>&1; then
colorized_echo yellow "Image $image removed"
else
colorized_echo yellow "Failed to remove image $image"
fi
done
}

uninstall_pasarguard_data_files() {
Expand Down
31 changes: 23 additions & 8 deletions pg-node.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,15 +772,30 @@ uninstall_node() {
fi
}
uninstall_node_docker_images() {
images=$(docker images | grep node | awk '{print $3}')
if [ -n "$images" ]; then
colorized_echo yellow "Removing Docker images of node"
for image in $images; do
if docker rmi "$image" >/dev/null 2>&1; then
colorized_echo yellow "Image $image removed"
fi
done
local images
images=$(docker images --format '{{.Repository}} {{.ID}}' | awk '$1 ~ /^pasarguard\/node(:|$)/ {print $2}' | sort -u)

if [ -z "$images" ]; then
colorized_echo yellow "pasarguard/node images not found"
return 0
fi

colorized_echo yellow "Checking pasarguard/node images for removal..."

for image in $images; do
if docker ps -a --filter "ancestor=$image" -q | grep -q .; then
local container
container=$(docker ps -a --filter "ancestor=$image" --format '{{.Names}}' | tr '\n' ' ')
colorized_echo yellow "Skipping image $image (still used by: $container)"
continue
fi

if docker rmi "$image" >/dev/null 2>&1; then
colorized_echo yellow "Image $image removed"
else
colorized_echo yellow "Failed to remove image $image"
fi
done
}
uninstall_node_data_files() {
if [ -d "$DATA_DIR" ]; then
Expand Down