Skip to content

Add support for sObject Collections #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yukas wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add support for sObject Collections #1

yukas wants to merge 5 commits into from

Conversation

@yukas
Copy link

@yukas yukas commented Jan 14, 2019

No description provided.

@yukas yukas changed the title Add support for sObject Collections create call Add support for sObject Collections Jan 14, 2019
@yukas yukas requested a review from spectator January 14, 2019 12:43
@yukas
Copy link
Author

yukas commented Jan 14, 2019

@spectator At this point I only needed the create/update functionality for RP. There is also retrieve/delete functionality which sObject collections API provides. I can implement those too. Should I do it right away in this PR, or we can merge this one and let it be used on LP and I implement retrieve/delete in a separate PR?

@yukas yukas force-pushed the sobject-collections-support branch from 5ba72c5 to 75ea60e Compare January 14, 2019 12:51
@yukas yukas force-pushed the sobject-collections-support branch from 75ea60e to e9ecf30 Compare January 14, 2019 12:52
@spectator
Copy link

spectator commented Jan 14, 2019

@spectator At this point I only needed the create/update functionality for RP. There is also retrieve/delete functionality which sObject collections API provides. I can implement those too. Should I do it right away in this PR, or we can merge this one and let it be used on LP and I implement retrieve/delete in a separate PR?

Since we don't need retrieve/delete right now, let's finish create/update and RP functionality first, and then we'll discuss. Please submit PR to gem maintainers to add create/update when you have a moment.

@spectator spectator force-pushed the sobject-collections-support branch 2 times, most recently from 2373a58 to 92338ff Compare November 15, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@spectator spectator spectator approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yukas @spectator