Skip to content

Mofify signatures with an invalid v inflight #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zmanian wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Mofify signatures with an invalid v inflight #582

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1ac3bf
Mofify signatures with an invalid v inflight
zmanian Jun 28, 2025
f25dca1
Handle the other confirms and correct v values.
zmanian Jun 28, 2025
f677898
Updated V transformation and panic if sig is invalid after
zmanian Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 54 additions & 6 deletions orchestrator/gravity/src/query.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,24 @@ pub async fn get_all_valset_confirms(
item.ethereum_signer
);
debug!("reason given for invalid signature: {e:?}");

continue;
match e {
clarity::Error::InvalidV => {
let mut corrected_sig = item.signature.clone();
corrected_sig[64] += 27;
let mut corrected = item.clone();
corrected.signature = corrected_sig;
Signature::from_bytes(&corrected.signature)?
.error_check()
.unwrap();
debug!("Corrected the V value on signature");
parsed_confirms.push(ValsetConfirmResponse::from_proto(corrected)?);
continue;
//Do not skip the signature if the V value is invalid.
}
_ => {
continue;
}
}
}

parsed_confirms.push(ValsetConfirmResponse::from_proto(item)?)
Expand Down Expand Up @@ -148,7 +164,24 @@ pub async fn get_transaction_batch_signatures(
);
debug!("reason given for invalid signature: {e:?}");

continue;
match e {
clarity::Error::InvalidV => {
let mut corrected_sig = confirm.signature.clone();
corrected_sig[64] += 27;
let mut corrected = confirm.clone();
corrected.signature = corrected_sig;
Signature::from_bytes(&corrected.signature)?
.error_check()
.unwrap();
debug!("Corrected the V value on signature");
out.push(BatchConfirmResponse::from_proto(corrected)?);
continue;
//Do not skip the signature if the V value is invalid.
}
_ => {
continue;
}
}
}

out.push(BatchConfirmResponse::from_proto(confirm)?)
Expand Down Expand Up @@ -211,9 +244,24 @@ pub async fn get_logic_call_signatures(
"ignoring logic call confirmation with invalid signature from {}",
confirm.ethereum_signer
);
debug!("reason given for invalid signature: {e:?}");

continue;
match e {
clarity::Error::InvalidV => {
let mut corrected_sig = confirm.signature.clone();
corrected_sig[64] += 27;
let mut corrected = confirm.clone();
corrected.signature = corrected_sig;
Signature::from_bytes(&corrected.signature)?
.error_check()
.unwrap();
debug!("Corrected the V value on signature");
out.push(LogicCallConfirmResponse::from_proto(corrected)?);
continue;
//Do not skip the signature if the V value is invalid.
}
_ => {
continue;
}
}
}

out.push(LogicCallConfirmResponse::from_proto(confirm)?)
Expand Down
Loading