Change the search button click behavior and always show topics

[ImTheKai]

Now, if you click the search bar, you will automatically end up on the topics page, and the sidebar search input field is highlighted. Only if there are search results, the actual search page will be shown.

This makes the search flow more intuitive compared to the current version.

[dutow]

Can we base it on an #anchor instead? instead of topics?focus=1, we could use topics#search, and autofocus on it using javascript.

With a little server side logic, we can make it even better:

• if we are on a page with the search sidebar set, the search link is only "#search"
• otherwise, it's topics_path(anchor: "search")

Which means that no matter on which page we are with a search bar, we'll never refresh/navigate to somewhere else if we don't have to.

[ImTheKai]

You're totally right @dutow and I adjusted the behavior now, as this feels way smoother and also avoids the unnecessary reload. I also dropped the search header from the sidebar, as this was already duplicated, as the search button itself "claims" the search.