Bugfix/initialization and data structure fixes#17
Open
mzietlow wants to merge 4 commits intoPetzys:masterfrom
Open
Bugfix/initialization and data structure fixes#17mzietlow wants to merge 4 commits intoPetzys:masterfrom
mzietlow wants to merge 4 commits intoPetzys:masterfrom
Conversation
… arrays instead to reduce complexity
…reaking follow-up logic. Ensure the result is either [] or ["<correct-path>"]
…sure proper initialization
…y for environment variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues related to handling alternating data structures when input parameters are provided via either command-line arguments or the
.envfile.It also resolves a problem with iterating over
song_sourcesby replacing a more cumbersome dictionary lookup with a simple array, making the logic easier to understand.Note:
usdb.animux.deis currently experiencing issues with zip downloads. This may be a good opportunity to consider adding alternative lyrics sources, although that work is outside the scope of this PR (and not something I could realistically tackle right now).