Skip to content

Conversation

@gin0115
Copy link
Contributor

@gin0115 gin0115 commented Dec 11, 2025

This pull request focuses on improving compatibility and reliability in the view rendering engine, particularly around path handling and dependency versions. The most important changes are the removal of dot notation resolution in view paths, updates to dependency requirements, and cleanup of related tests.

View Path Handling:

  • Removed the logic that attempted to resolve dot notation in the base view path of the PHP_Engine, as it caused issues when server folder names contained dots. This also removes the associated test for setting the base path using dot notation. [1] [2] [3]

Dependency Updates:

  • Updated the psr/container requirement in composer.json to allow both v1 and v2, improving compatibility with other packages.

Test Suite Cleanup:

  • Refactored docblocks in Test_PHP_Engine.php for consistency and readability, and removed the test related to dot notation in base paths. [1] [2] [3] [4] [5] [6]

gin0115 and others added 6 commits January 27, 2025 23:26
Updates the requirements on [psr/container](https://github.com/php-fig/container) to permit the latest version.
- [Release notes](https://github.com/php-fig/container/releases)
- [Commits](php-fig/container@1.0.0...2.0.2)

---
updated-dependencies:
- dependency-name: psr/container
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
…ner-tw-1.0or-tw-2.0

Update psr/container requirement from ^1.0 to ^1.0 || ^2.0
…not-dot-nations

remove the attempt to resolve dot nations in base view paths and remo…
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8268084) to head (513e6c7).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #211   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       234       234           
===========================================
  Files             22        22           
  Lines            694       693    -1     
===========================================
- Hits             694       693    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gin0115 gin0115 merged commit faa0231 into master Dec 11, 2025
34 of 35 checks passed
@gin0115 gin0115 deleted the release/2.1.1 branch December 11, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants