Ensure that additional adata columns are not removed in the denoise step#307
Merged
Ensure that additional adata columns are not removed in the denoise step#307
Conversation
johandahlberg
approved these changes
Feb 18, 2026
Contributor
johandahlberg
left a comment
There was a problem hiding this comment.
See my inline comment. Lets fix that and then merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Information added to adata are removed in the denoise step. This happens because marker adata is recalculated since denoising changes marker counts for each component and some of the statistics should be recalculated. The fix is to add back any columns that are missing in the new adata from the old adata.
Fixes: #PNA-2075
Type of change
How Has This Been Tested?
We now add a dummy column before denoising and check if it still exists after denoising.
PR checklist:
pyproject.tomland cited it properly