Conversation
There was a problem hiding this comment.
Pull request overview
This PR cleans up the package's dependency declarations by removing unused NAMESPACE imports and standardizing the pipe operator usage from the native R pipe (|>) to the magrittr/dplyr pipe (%>%).
Changes:
- Removed 19 unused function imports across multiple packages (dplyr, ggplot2, knitr, pixelatorR, readr, rlang, stats, tidyr)
- Unified pipe operator usage in R/params.R from
|>to%>% - Reordered dependencies in DESCRIPTION (dbplyr moved to alphabetical position)
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| R/pixelatorES-package.R | Removed unused import declarations for functions no longer used in the codebase |
| R/params.R | Standardized pipe operator from ` |
| NAMESPACE | Synchronized with package.R changes by removing corresponding importFrom declarations |
| DESCRIPTION | Reordered dbplyr import alphabetically in the dependencies list |
| CHANGELOG.md | Documented the removal of unused imports in the Unreleased section |
| .Rbuildignore | Added utility directory to build ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| magick, | ||
| magick, | ||
| dbplyr, | ||
| RcppML |
There was a problem hiding this comment.
The stats package was removed from the Imports list, but it is still being imported in NAMESPACE (lines 216-223 in the diff). R packages in Imports should include all packages from which functions are imported via @importFrom directives. Verify that stats is a base R package that doesn't need to be listed in Imports, or restore it to the dependencies.
| RcppML | |
| RcppML, | |
| stats |
Description
Removed unused NAMESPACE imports and unified pipe operator.
Fixes: PNA-1208