Skip to content

Removed unused NAMESPACE imports#58

Merged
ludvigla merged 4 commits intomainfrom
pna-1208
Feb 12, 2026
Merged

Removed unused NAMESPACE imports#58
ludvigla merged 4 commits intomainfrom
pna-1208

Conversation

@ludvigla
Copy link
Contributor

@ludvigla ludvigla commented Feb 2, 2026

Description

Removed unused NAMESPACE imports and unified pipe operator.

Fixes: PNA-1208

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up the package's dependency declarations by removing unused NAMESPACE imports and standardizing the pipe operator usage from the native R pipe (|>) to the magrittr/dplyr pipe (%>%).

Changes:

  • Removed 19 unused function imports across multiple packages (dplyr, ggplot2, knitr, pixelatorR, readr, rlang, stats, tidyr)
  • Unified pipe operator usage in R/params.R from |> to %>%
  • Reordered dependencies in DESCRIPTION (dbplyr moved to alphabetical position)

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
R/pixelatorES-package.R Removed unused import declarations for functions no longer used in the codebase
R/params.R Standardized pipe operator from `
NAMESPACE Synchronized with package.R changes by removing corresponding importFrom declarations
DESCRIPTION Reordered dbplyr import alphabetically in the dependencies list
CHANGELOG.md Documented the removal of unused imports in the Unreleased section
.Rbuildignore Added utility directory to build ignore list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

magick,
magick,
dbplyr,
RcppML
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stats package was removed from the Imports list, but it is still being imported in NAMESPACE (lines 216-223 in the diff). R packages in Imports should include all packages from which functions are imported via @importFrom directives. Verify that stats is a base R package that doesn't need to be listed in Imports, or restore it to the dependencies.

Suggested change
RcppML
RcppML,
stats

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

@maxkarlsson maxkarlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@ludvigla ludvigla merged commit c0c12b6 into main Feb 12, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments