Skip to content

feat(HNT-1398): add Canada and Ireland #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmiermans merged 4 commits into from
Jan 20, 2026
Merged

feat(HNT-1398): add Canada and Ireland #1266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e919d70
feat(HNT-1398): add Canada and Ireland
mmiermans Jan 14, 2026
c3d1741
Fix test
mmiermans Jan 15, 2026
c1ea287
Reorder surfaces
mmiermans Jan 15, 2026
7277659
Fix failing test (2)
mmiermans Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/curated-corpus/components/ApprovedItemListCard/ApprovedItemListCard.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,13 +167,13 @@ describe('The ApprovedItemListCard component', () => {
createdBy: 'ad|Mozilla-LDAP|aperson',
externalId: 'bogus-external-id',
scheduledDate: '2022-08-01',
scheduledSurfaceGuid: ScheduledSurfaces[0].guid,
scheduledSurfaceGuid: 'NEW_TAB_EN_US',
},
{
createdBy: 'ad|Mozilla-LDAP|bperson',
externalId: 'useless-external-id',
scheduledDate: '2022-08-02',
scheduledSurfaceGuid: ScheduledSurfaces[1].guid,
scheduledSurfaceGuid: 'NEW_TAB_DE_DE',
},
],
};
Expand Down
4 changes: 2 additions & 2 deletions src/curated-corpus/components/ScheduleHistoryModal/ScheduleHistoryModal.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ describe('The ScheduleHistoryModal component', () => {
createdBy: 'ad|Mozilla-LDAP|aperson',
externalId: 'bogus-external-id',
scheduledDate: '2022-08-01',
scheduledSurfaceGuid: ScheduledSurfaces[0].guid,
scheduledSurfaceGuid: 'NEW_TAB_EN_US',
},
{
createdBy: 'ad|Mozilla-LDAP|bperson',
externalId: 'useless-external-id',
scheduledDate: '2022-08-02',
scheduledSurfaceGuid: ScheduledSurfaces[1].guid,
scheduledSurfaceGuid: 'NEW_TAB_DE_DE',
},
],
};
Expand Down
4 changes: 3 additions & 1 deletion src/curated-corpus/components/ScheduleItemFormConnector/ScheduleItemFormConnector.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,10 @@ describe('ScheduleItemFormConnector', () => {

const scheduledSurfaceValues = [
'NEW_TAB_EN_US',
'NEW_TAB_EN_GB',
'NEW_TAB_EN_CA',
'NEW_TAB_DE_DE',
'NEW_TAB_EN_GB',
'NEW_TAB_EN_IE',
'NEW_TAB_EN_INTL',
'POCKET_HITS_EN_US',
'POCKET_HITS_DE_DE',
Expand Down
2 changes: 2 additions & 0 deletions src/curated-corpus/helpers/definitions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,10 @@ export type ApprovedItemFromProspect = Omit<
// List of scheduled surfaces used to show the readable name by mapping it to it's corresponding guid
export const ScheduledSurfaces = [
{ guid: 'NEW_TAB_EN_US', name: 'New Tab (en-US)' },
{ guid: 'NEW_TAB_EN_CA', name: 'New Tab (en-CA)' },
{ guid: 'NEW_TAB_DE_DE', name: 'New Tab (de-DE)' },
{ guid: 'NEW_TAB_EN_GB', name: 'New Tab (en-GB)' },
{ guid: 'NEW_TAB_EN_IE', name: 'New Tab (en-IE)' },
{ guid: 'NEW_TAB_FR_FR', name: 'New Tab (fr-FR)' },
{ guid: 'NEW_TAB_IT_IT', name: 'New Tab (it-IT)' },
{ guid: 'NEW_TAB_ES_ES', name: 'New Tab (es-ES)' },
Expand Down
14 changes: 13 additions & 1 deletion src/curated-corpus/integration-test-mocks/getScheduledSurfacesForUser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,18 @@ const allScheduledSurfaces: ScheduledSurface[] = [
ProspectType.Dismissed,
],
},
{
name: 'New Tab (en-CA)',
guid: 'NEW_TAB_EN_CA',
ianaTimezone: 'America/Toronto',
prospectTypes: [],
},
{
name: 'New Tab (en-IE)',
guid: 'NEW_TAB_EN_IE',
ianaTimezone: 'Europe/Dublin',
prospectTypes: [],
},
{
name: 'New Tab (en-INTL)',
guid: 'NEW_TAB_EN_INTL',
Expand Down Expand Up @@ -121,5 +133,5 @@ export const mock_OneScheduledSurface = constructMock(
'getScheduledSurfacesForUser',
getScheduledSurfacesForUser,
undefined,
allScheduledSurfaces.slice(4, 5),
allScheduledSurfaces.filter((s) => s.guid === 'POCKET_HITS_EN_US'),
);