added Avro support for KafkaAdapter #645
Open
+4,303
−432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildek
requested review from
AdamGlustein,
alexddobkin,
ptomecek,
robambalu,
svatasoiu and
timkpaine
as code owners
Signed-off-by: Krzysztof Milde <Krzysztof.Milde@Point72.com>
mildek
force-pushed
the
feat/add-kafka-avro-protocol
branch
from
b76ceb9 to
e3ea18f
Compare
…rotocol Signed-off-by: Krzysztof Milde <Krzysztof.Milde@Point72.com>
mildek
force-pushed
the
feat/add-kafka-avro-protocol
branch
from
1238242 to
8ce67ec
Compare
Signed-off-by: Krzysztof Milde <Krzysztof.Milde@Point72.com>
mildek
force-pushed
the
feat/add-kafka-avro-protocol
branch
2 times, most recently
from
61090fb to
e6af9f8
Compare
Signed-off-by: Krzysztof Milde <Krzysztof.Milde@Point72.com>
mildek
force-pushed
the
feat/add-kafka-avro-protocol
branch
from
e6af9f8 to
aa8a87b
Compare
timkpaine
reviewed
Dec 11, 2025
timkpaine
reviewed
Dec 11, 2025
Signed-off-by: Krzysztof Milde <Krzysztof.Milde@Point72.com>
mildek
force-pushed
the
feat/add-kafka-avro-protocol
branch
2 times, most recently
from
ee61ade to
2b8dfca
Compare
Signed-off-by: Krzysztof Milde <Krzysztof.Milde@Point72.com>
mildek
force-pushed
the
feat/add-kafka-avro-protocol
branch
from
2b8dfca to
1f4ab48
Compare
The avro-cpp library added in this PR uses fmt, which requires the /utf-8 compiler flag on Windows MSVC to handle Unicode support properly. Signed-off-by: Krzysztof Milde <Krzysztof.Milde@Point72.com>
…ndows. The avro-cpp library from conda-forge defines fmt::formatter<avro::Name> with a non-const format() method, but fmt v12 requires it to be const. This commit adds a const-correct version of the formatter that is used on Windows (MSVC) to prevent compilation errors. Signed-off-by: Krzysztof Milde <Krzysztof.Milde@Point72.com>
The avro-cpp library is not yet compatible with fmt v12. The library defines fmt::formatter<avro::Name> with a non-const format() method, but fmt v12 requires it to be const. Homebrew and other package managers use fmt 11.2.0 with avro-cpp, so we pin fmt<12 in the Windows conda environment to avoid compilation errors on Windows CI. Signed-off-by: Krzysztof Milde <Krzysztof.Milde@Point72.com>
timkpaine
previously requested changes
Jan 14, 2026
Instead of pinning to an older fmt version (which creates version mismatch between platforms), we implement a workaround that provides a const-correct fmt::formatter<avro::Name> specialization on Windows. conda-forge's avro-cpp has an outdated formatter without const, while fmt v11+ requires const. We define the correct version first and suppress the redefinition warning, ensuring compatibility with latest fmt across all platforms. Also regenerated NOTICE file to include avro-cpp license. Signed-off-by: Krzysztof Milde <Krzysztof.Milde@Point72.com>
conda-forge's avro-cpp defines fmt::formatter with non-const format() method, but fmt v11+ requires const. Create a centralized AvroIncludes.h wrapper that: 1. Temporarily sets FMT_VERSION to 80000 (below 90000 threshold) to prevent avro from defining its broken formatters 2. Includes all avro headers 3. Restores FMT_VERSION and defines const-correct formatters for both avro::Name and avro::Type This can be removed once conda-forge updates avro-cpp. Signed-off-by: Krzysztof Milde <Krzysztof.Milde@Point72.com>
mildek
force-pushed
the
feat/add-kafka-avro-protocol
branch
from
9632b13 to
e9d65cb
Compare
…ty on Windows Signed-off-by: Krzysztof Milde <Krzysztof.Milde@Point72.com>
mildek
force-pushed
the
feat/add-kafka-avro-protocol
branch
from
29a3554 to
acd75a1
Compare
timkpaine
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.