Rollback to official source when any errors occur in the image #6636

f401 · 2025-02-17T06:04:46Z

No description provided.

Mathias-Boulay · 2025-02-20T15:52:24Z

Hi there @f401, thank you for bringing your concern through a contribution.

However, it would be preferable to know what kind of Exception we want to catch from the mirror. If you want to catch more exception types to handle them differently, be less broad than this in your catch statement.

Mathias-Boulay

The handling regarding some exceptions leaves a bit to be desired.
For example, if one was to have the unknown host exception on a single file from a mirror, it is pretty much expected for said exception to resurface for every single file.

Suggestion: Make the DownloadMirror class non-static and make it aware of the failures when trying to download from a mirror.

Mathias-Boulay · 2025-02-22T21:56:40Z

app_pojavlauncher/src/main/java/net/kdt/pojavlaunch/utils/DownloadUtils.java

            conn.connect();
            if (conn.getResponseCode() != HttpURLConnection.HTTP_OK) {
-                throw new IOException("Server returned HTTP " + conn.getResponseCode()
+                // We may be on the mirror, just give it a chance to rollback to official


This comment should not be there. download is a general purpose function.

Suggestion: remove the comment

Removed comment

Mathias-Boulay · 2025-02-22T22:01:52Z

app_pojavlauncher/src/main/java/net/kdt/pojavlaunch/utils/DownloadUtils.java

            if (conn.getResponseCode() != HttpURLConnection.HTTP_OK) {
-                throw new IOException("Server returned HTTP " + conn.getResponseCode()
+                // We may be on the mirror, just give it a chance to rollback to official
+                throw new SocketException("Server returned HTTP " + conn.getResponseCode()


Wrong Exception kind, as on a technical level, the communication was executed successfully.

Suggestion: Create an alternate Exception type like HttpException

Created HttpException

Mathias-Boulay · 2025-02-22T22:06:39Z

app_pojavlauncher/src/main/java/net/kdt/pojavlaunch/utils/DownloadUtils.java

+            try (InputStream is = conn.getInputStream()) {
+                IOUtils.copy(is, os);
            }
+        } catch (IOException e) { // Here Is Socket Exception


suggestion: remove comment

removed comment

f401 · 2025-02-24T09:01:13Z

The handling regarding some exceptions leaves a bit to be desired. For example, if one was to have the unknown host exception on a single file from a mirror, it is pretty much expected for said exception to resurface for every single file.

Suggestion: Make the DownloadMirror class non-static and make it aware of the failures when trying to download from a mirror.

According to https://github.com/bangbang93/openbmclapi.
bmclapi distributes files through OpenBMCLAPI, and the inability to download a single file does not mean that the entire mirror is unavailable

Mathias-Boulay · 2025-02-24T19:39:22Z

According to https://github.com/bangbang93/openbmclapi. bmclapi distributes files through OpenBMCLAPI, and the inability to download a single file does not mean that the entire mirror is unavailable

This is indeed right. However, my statement is right as well, but allow me to reformulate it for you:
Some exceptions like UnknownHostException can happen. Http error codes 500+ are valid reason to fallback on the official mirror for all download if encountered. Missing files on a mirror should return 404 (hopefully) or 403/401.

Mathias-Boulay

Somes changes have to be made, see my comment outside of the review as well.

Mathias-Boulay · 2025-02-24T20:00:29Z

app_pojavlauncher/src/main/java/net/kdt/pojavlaunch/mirrors/HttpException.java

+
+public class HttpException extends IOException {
+    // Do not change. Android really hates when this value changes for some reason.
+    private static final long serialVersionUID = -7372301619612640655L;


question: Can you elaborate on why this line is here ?
In my limited testing, I failed to see what it changed.

Mathias-Boulay · 2025-02-24T20:06:13Z

app_pojavlauncher/src/main/java/net/kdt/pojavlaunch/mirrors/HttpException.java

+    // Do not change. Android really hates when this value changes for some reason.
+    private static final long serialVersionUID = -7372301619612640655L;
+
+    public HttpException(String msg) {


suggestion: The Exception should take an http code accessible to the catch block of Exception
handlers.

f401 · 2025-02-26T14:09:48Z

@Mathias-Boulay
Please allow me to explain again (please forgive my poor English level):
Firstly, the exceptions I added in the catch block were all obtained through actual testing. (Thank you for forgiving my poor programming language skills and your patience)
There are two situations where an UnknownHostException occurs: https://bmclapi2.bangbang93.com itself throwing an UnknownHostException or an UnknownHostException distributed to nodes by openbmclapi. In my understanding, what you are referring to is the former. The former is because the image did indeed fail, and the UnknownHostException I obtained during my testing was the latter. Similarly, it is uncertain whether HTTP Code 500+ is thrown by the former or the latter. Additionally, please find attached a test code from me

import java.io.FileOutputStream
import java.io.IOException
import java.net.HttpURLConnection
import java.net.URL

fun main() {
    val url = "https://bmclapi2.bangbang93.com/version/1.7.10/client"
    var hitCount = 0
    var code: Int = -1;
    do {
        val connection =
            URL(url).openConnection() as HttpURLConnection
        try {
            connection.connect()
            code = connection.responseCode
            ++hitCount
            val fos = FileOutputStream("/tmp/t.jar")
            connection.inputStream.copyTo(fos)
            fos.close()
        } catch (e: IOException) {
            e.printStackTrace()
        }

        connection.disconnect()
    } while (code == HttpURLConnection.HTTP_OK)
    println("Code $code, hit count $hitCount")
}

result:

java.io.FileNotFoundException: https://download.cloud.189.cn/notfound/notfound.jsp
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
	at java.base/sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:2093)
	at java.base/sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:2088)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:569)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getChainedException(HttpURLConnection.java:2087)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1645)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1625)
	at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:224)
	at org.example.MainKt.main(Main.kt:20)
	at org.example.MainKt.main(Main.kt)
Caused by: java.io.FileNotFoundException: https://download.cloud.189.cn/notfound/notfound.jsp
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:2032)
	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1625)
	at java.base/java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:529)
	at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:308)
	at org.example.MainKt.main(Main.kt:17)
	... 1 more
Code 404, hit count 174

It can be seen that the probability of encountering a 404 error when downloading the same file is low. It also confirms that there may be issues with the child nodes. Here is also an unresolved issue with OpenBMCLAPI regarding the validation of HTTP Code availability for child nodes (written in Chinese) bangbang93/openbmclapi#8. My personal opinion: The above is due to implementation issues with the BMCLAPI source. It cannot be ruled out that other sources may be added in the future. Perhaps internal service errors in the download source can be resolved by rolling back the subsequent downloads to the official source (your suggestion) as a launcher preference option.

Rollback to official source when any errors occur in the image

f4c22a5

More detailed exception capture

e2b9a6a

Mathias-Boulay self-requested a review February 22, 2025 21:37

Mathias-Boulay suggested changes Feb 22, 2025

View reviewed changes

Remove comment; Added HttpException

eb7c5e4

f401 requested a review from Mathias-Boulay February 24, 2025 08:59

Mathias-Boulay suggested changes Feb 24, 2025

View reviewed changes

User decides to roll back the official source

30f40e1

f401 requested a review from Mathias-Boulay February 28, 2025 11:44

Uh oh!

Rollback to official source when any errors occur in the image #6636

Are you sure you want to change the base?

Rollback to official source when any errors occur in the image #6636

Uh oh!

Conversation

f401 commented Feb 17, 2025

Uh oh!

Mathias-Boulay commented Feb 20, 2025

Uh oh!

Mathias-Boulay left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

f401 commented Feb 24, 2025

Uh oh!

Mathias-Boulay commented Feb 24, 2025

Uh oh!

Mathias-Boulay left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

f401 commented Feb 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants