Skip to content

Queue events broadcasted while we are disconnected#101

Open
denmeh wants to merge 6 commits intomasterfrom
Queue-events-broadcasted-while-we-are-disconnected
Open

Queue events broadcasted while we are disconnected#101
denmeh wants to merge 6 commits intomasterfrom
Queue-events-broadcasted-while-we-are-disconnected

Conversation

@denmeh
Copy link
Member

@denmeh denmeh commented Oct 6, 2025

Closes issue #86 .
It needs task #98 before it is merged.

@denmeh denmeh changed the base branch from master to refactor-message-router-state October 6, 2025 14:29
@denmeh denmeh force-pushed the Queue-events-broadcasted-while-we-are-disconnected branch from 680b7e9 to 73de380 Compare October 6, 2025 14:30
@denmeh denmeh marked this pull request as ready for review October 7, 2025 09:35
@denmeh denmeh force-pushed the refactor-message-router-state branch 2 times, most recently from b342cdc to 2ec6cff Compare October 7, 2025 10:27
@denmeh denmeh requested a review from Copilot October 7, 2025 10:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Implements queued retry logic for broadcasting Nostr events when initial relay delivery fails.

  • Extends Channel trait: broadcast methods now take &Event and return a HashSet of failed relay URLs instead of ().
  • Introduces QueuedEvent with asynchronous retry (linear backoff) for failed relays.
  • CLI now accepts a provided relay list instead of a hard-coded set.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 8 comments.

File Description
src/router/channel.rs Alters Channel trait API and RelayPool implementation to report failed relays.
src/router/actor.rs Adds QueuedEvent abstraction and retry task for undelivered events.
cli/src/lib.rs Switches to using relays parameter instead of hard-coded relay list.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@denmeh denmeh force-pushed the Queue-events-broadcasted-while-we-are-disconnected branch from d458b85 to cd047ed Compare October 7, 2025 12:26
@denmeh denmeh requested a review from Copilot October 7, 2025 12:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 6 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@denmeh denmeh force-pushed the Queue-events-broadcasted-while-we-are-disconnected branch from cd047ed to 7a8c8ee Compare October 7, 2025 12:37
@denmeh denmeh requested a review from afilini October 7, 2025 12:38
@denmeh denmeh changed the base branch from refactor-message-router-state to master October 7, 2025 12:42
@denmeh denmeh added the portal portal main crate label Dec 10, 2025
@denmeh denmeh force-pushed the master branch 4 times, most recently from 0526c98 to cb88384 Compare February 12, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

portal portal main crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant