Queue events broadcasted while we are disconnected#101
Open
Queue events broadcasted while we are disconnected#101
Conversation
680b7e9 to
73de380
Compare
b342cdc to
2ec6cff
Compare
There was a problem hiding this comment.
Pull Request Overview
Implements queued retry logic for broadcasting Nostr events when initial relay delivery fails.
- Extends Channel trait: broadcast methods now take &Event and return a HashSet of failed relay URLs instead of ().
- Introduces QueuedEvent with asynchronous retry (linear backoff) for failed relays.
- CLI now accepts a provided relay list instead of a hard-coded set.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| src/router/channel.rs | Alters Channel trait API and RelayPool implementation to report failed relays. |
| src/router/actor.rs | Adds QueuedEvent abstraction and retry task for undelivered events. |
| cli/src/lib.rs | Switches to using relays parameter instead of hard-coded relay list. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
d458b85 to
cd047ed
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 6 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cd047ed to
7a8c8ee
Compare
0526c98 to
cb88384
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #86 .
It needs task #98 before it is merged.