Skip to content

Reusable 'Resource loading' presentation #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PortoCode merged 21 commits into from
Mar 15, 2025
Merged

Reusable 'Resource loading' presentation #39

PortoCode merged 21 commits into from
Mar 15, 2025

Conversation

@PortoCode
Copy link
Owner

@PortoCode PortoCode commented Mar 15, 2025

  • Introduce reusable LoadResourcePresenter.
  • Replace custom FeedPresenter and FeedImagePresenter logic with LoadResourcePresenter to eliminate duplication.

Architecture overview

image

PortoCode added 21 commits March 14, 2025 07:31
@PortoCode
Duplicate FeedPresenter as LoadResourcePresenter
6753975
@PortoCode
Remove title from generic presenter since it's specific to each prese…
0ad2f37 
…nter
@PortoCode
Rename method
769ffe7
@PortoCode
Displays mapped resource on successful resource loading
7c8a5c7
@PortoCode
Make LoadResourcePresenter generic over the Resource types
c3b777c
@PortoCode
Replace "FEED_VIEW_CONNECTION_ERROR" key with "GENERIC_CONNECTION_ERROR"
2208bfb
@PortoCode
Move "GENERIC_CONNECTION_ERROR" localization key to new Shared.strings
18afb6c
@PortoCode
Remove duplication in the localization tests
cdd6e74
@PortoCode
Rename and move ResourceLoadingView and VIewModel to Shared module
729614c
@PortoCode
Rename and move ResourceErrorView and ViewModel to Shared module
75d7efb
@PortoCode
Add FeedPresenter map
0535344
@PortoCode
Replace FeedPresenter with generic presenter
f3530e2
@PortoCode
Remove unused FeedPresenter logic
ccb605f
@PortoCode
Inline param
48025c5
@PortoCode
Make Presentation Adapter generic so it can be reused
923e056
@PortoCode
Add FeedImagePresenter map
4792a1d
@PortoCode
Display error on mapper error
b520129
@PortoCode
Replace FeedImagePresenter with LoadResourcePresenter
b7d85d2
@PortoCode
Remove unused FeedImagePresenter logic
855a22f
@PortoCode
Add type aliases to shorten type definitions with generics
83ac9c1
@PortoCode
Move UIImage creation to a tryMake extension
1028394
@PortoCode PortoCode self-assigned this Mar 15, 2025
@PortoCode PortoCode merged commit 9e43f4c into main Mar 15, 2025
2 checks passed
@PortoCode PortoCode deleted the refactor/reusable-resource-loading-presentation branch March 15, 2025 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@PortoCode PortoCode

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PortoCode